Skip to content

branch-3.0: [Chore](runtime-filter) change some rf dcheck to exception #44354#44371

Merged
BiteTheDDDDt merged 2 commits into
branch-3.0from
auto-pick-44354-branch-3.0
Nov 27, 2024
Merged

branch-3.0: [Chore](runtime-filter) change some rf dcheck to exception #44354#44371
BiteTheDDDDt merged 2 commits into
branch-3.0from
auto-pick-44354-branch-3.0

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Cherry-picked from #44354

### What problem does this PR solve?

change some rf dcheck to exception
@doris-robot

Copy link
Copy Markdown

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Nov 21, 2024
@doris-robot

Copy link
Copy Markdown

run buildall

@github-actions

Copy link
Copy Markdown
Contributor Author

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

Copy link
Copy Markdown
TPC-H: Total hot run time: 40187 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c14449c6e076f0bd301747d3fe1781586387270a, data reload: false

------ Round 1 ----------------------------------
q1	17574	7386	7346	7346
q2	2065	161	154	154
q3	10678	1023	1144	1023
q4	10558	734	777	734
q5	7733	2807	2728	2728
q6	240	143	141	141
q7	965	605	591	591
q8	9572	1891	1977	1891
q9	7967	6398	6424	6398
q10	6946	2276	2285	2276
q11	456	254	259	254
q12	392	205	201	201
q13	17787	2986	2988	2986
q14	236	198	207	198
q15	573	517	519	517
q16	680	600	608	600
q17	950	539	495	495
q18	7202	6493	6592	6493
q19	1944	998	988	988
q20	466	185	192	185
q21	3876	3228	3012	3012
q22	1107	981	976	976
Total cold run time: 109967 ms
Total hot run time: 40187 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7299	7266	7269	7266
q2	319	223	222	222
q3	2889	2859	2871	2859
q4	2016	1842	1751	1751
q5	5635	5725	5670	5670
q6	221	149	140	140
q7	2192	1779	1770	1770
q8	3278	3554	3433	3433
q9	8775	8866	8814	8814
q10	3543	3472	3521	3472
q11	586	482	474	474
q12	800	598	594	594
q13	16533	3104	3142	3104
q14	302	269	265	265
q15	560	522	524	522
q16	730	689	645	645
q17	1856	1632	1568	1568
q18	8115	7802	7518	7518
q19	3363	1604	1614	1604
q20	2031	1859	1806	1806
q21	5314	5261	5197	5197
q22	1157	1045	985	985
Total cold run time: 77514 ms
Total hot run time: 59679 ms

@doris-robot

Copy link
Copy Markdown
TPC-DS: Total hot run time: 192871 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c14449c6e076f0bd301747d3fe1781586387270a, data reload: false

query1	1247	909	930	909
query2	6233	2124	2062	2062
query3	10919	3910	3738	3738
query4	67740	28118	23475	23475
query5	5569	476	441	441
query6	422	170	165	165
query7	5861	298	297	297
query8	300	211	212	211
query9	9010	2626	2619	2619
query10	505	277	252	252
query11	17574	15042	15678	15042
query12	173	101	102	101
query13	1538	414	393	393
query14	10653	6544	7226	6544
query15	223	191	176	176
query16	7383	528	501	501
query17	1052	549	531	531
query18	1855	292	293	292
query19	197	140	133	133
query20	111	106	108	106
query21	201	98	105	98
query22	4399	4294	4440	4294
query23	33813	33354	33584	33354
query24	5859	2726	2778	2726
query25	524	391	367	367
query26	659	157	155	155
query27	1707	288	282	282
query28	4335	2519	2498	2498
query29	657	419	409	409
query30	225	158	150	150
query31	978	793	800	793
query32	64	49	50	49
query33	387	255	259	255
query34	886	478	486	478
query35	814	710	703	703
query36	1057	929	907	907
query37	112	67	69	67
query38	4008	3862	3871	3862
query39	1472	1411	1408	1408
query40	197	95	95	95
query41	47	45	47	45
query42	101	94	93	93
query43	529	488	505	488
query44	1104	773	780	773
query45	176	164	156	156
query46	1100	690	690	690
query47	1888	1837	1800	1800
query48	455	365	351	351
query49	728	362	370	362
query50	800	402	407	402
query51	7245	7056	6943	6943
query52	101	91	89	89
query53	257	185	186	185
query54	543	445	441	441
query55	77	78	73	73
query56	245	246	248	246
query57	1165	1115	1133	1115
query58	221	210	205	205
query59	3208	2954	2889	2889
query60	285	259	254	254
query61	126	123	132	123
query62	773	662	672	662
query63	219	183	178	178
query64	1595	727	700	700
query65	3240	3167	3155	3155
query66	731	319	305	305
query67	15779	15386	15338	15338
query68	3576	541	542	541
query69	404	250	257	250
query70	1185	1138	1104	1104
query71	337	252	252	252
query72	6355	3922	3910	3910
query73	734	338	334	334
query74	9937	8948	8892	8892
query75	3323	2591	2597	2591
query76	1940	1031	1009	1009
query77	474	270	260	260
query78	10681	9533	9546	9533
query79	8781	579	596	579
query80	2408	408	424	408
query81	560	237	239	237
query82	1362	113	121	113
query83	306	139	139	139
query84	287	77	79	77
query85	1947	305	287	287
query86	473	275	299	275
query87	4317	4184	4243	4184
query88	5649	2330	2319	2319
query89	557	290	288	288
query90	2112	178	182	178
query91	176	145	143	143
query92	69	46	47	46
query93	6559	538	531	531
query94	978	292	291	291
query95	346	241	242	241
query96	622	272	278	272
query97	3315	3171	3107	3107
query98	224	208	203	203
query99	1651	1304	1278	1278
Total cold run time: 335302 ms
Total hot run time: 192871 ms

@BiteTheDDDDt

Copy link
Copy Markdown
Contributor

run buildall

@github-actions

Copy link
Copy Markdown
Contributor Author

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot

Copy link
Copy Markdown
TPC-H: Total hot run time: 40679 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit dd8382011e8a465005d2a0fe9f87254dd12a2558, data reload: false

------ Round 1 ----------------------------------
q1	17846	7535	7397	7397
q2	2449	168	154	154
q3	10642	1127	1146	1127
q4	10218	766	749	749
q5	7739	2892	2819	2819
q6	239	147	149	147
q7	951	615	599	599
q8	9345	1954	1974	1954
q9	6655	6406	6394	6394
q10	6998	2286	2315	2286
q11	460	267	260	260
q12	399	226	217	217
q13	17788	2944	2993	2944
q14	239	205	209	205
q15	559	534	510	510
q16	673	606	607	606
q17	961	499	583	499
q18	7308	6537	6449	6449
q19	1657	1141	1025	1025
q20	479	195	191	191
q21	3927	3245	3155	3155
q22	1101	997	992	992
Total cold run time: 108633 ms
Total hot run time: 40679 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7433	7236	7257	7236
q2	325	223	227	223
q3	2875	3081	2940	2940
q4	1989	1727	1796	1727
q5	5710	5655	5637	5637
q6	216	136	137	136
q7	2197	1754	1756	1754
q8	3326	3498	3458	3458
q9	8897	8804	8814	8804
q10	3559	3549	3484	3484
q11	585	503	513	503
q12	814	591	604	591
q13	17165	3143	2970	2970
q14	305	254	251	251
q15	553	508	506	506
q16	694	665	648	648
q17	1811	1585	1582	1582
q18	7576	7367	7199	7199
q19	7025	1562	1624	1562
q20	2002	1771	1774	1771
q21	5220	5105	5114	5105
q22	1068	977	971	971
Total cold run time: 81345 ms
Total hot run time: 59058 ms

@doris-robot

Copy link
Copy Markdown
TPC-DS: Total hot run time: 189256 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit dd8382011e8a465005d2a0fe9f87254dd12a2558, data reload: false

query1	981	371	361	361
query2	6523	2204	2082	2082
query3	6707	213	217	213
query4	33910	23481	23366	23366
query5	4361	458	440	440
query6	258	165	163	163
query7	4616	306	313	306
query8	284	230	213	213
query9	9611	2669	2651	2651
query10	461	265	262	262
query11	18187	15137	15105	15105
query12	151	103	101	101
query13	1656	416	403	403
query14	10291	6467	6612	6467
query15	214	179	178	178
query16	7799	475	472	472
query17	1202	571	554	554
query18	1969	304	299	299
query19	213	155	148	148
query20	118	109	111	109
query21	208	105	101	101
query22	4411	4371	4174	4174
query23	34672	33543	33587	33543
query24	12575	2928	2905	2905
query25	689	368	383	368
query26	1877	161	167	161
query27	3034	297	292	292
query28	8368	2521	2476	2476
query29	1193	422	413	413
query30	336	157	151	151
query31	1039	804	796	796
query32	90	55	55	55
query33	783	277	268	268
query34	1016	498	493	493
query35	943	709	725	709
query36	1098	931	945	931
query37	275	71	71	71
query38	4016	3922	3895	3895
query39	1488	1401	1406	1401
query40	281	97	100	97
query41	51	47	45	45
query42	103	101	100	100
query43	512	498	489	489
query44	1266	777	789	777
query45	181	164	165	164
query46	1114	722	731	722
query47	1872	1771	1787	1771
query48	454	366	373	366
query49	1291	372	369	369
query50	791	401	399	399
query51	7188	7111	6990	6990
query52	96	90	90	90
query53	256	185	185	185
query54	1317	436	442	436
query55	80	77	75	75
query56	245	234	236	234
query57	1232	1089	1100	1089
query58	233	205	207	205
query59	3211	2862	2864	2862
query60	269	248	252	248
query61	103	103	98	98
query62	864	667	647	647
query63	221	188	190	188
query64	5212	628	615	615
query65	3222	3209	3165	3165
query66	1426	302	293	293
query67	15770	15477	15314	15314
query68	4378	544	547	544
query69	408	264	265	264
query70	1203	1139	1129	1129
query71	355	252	252	252
query72	6339	4054	4046	4046
query73	746	348	361	348
query74	10159	9087	8889	8889
query75	3379	2636	2657	2636
query76	2699	989	1029	989
query77	385	263	268	263
query78	10554	9770	9468	9468
query79	6942	576	588	576
query80	1871	430	417	417
query81	579	239	241	239
query82	878	120	114	114
query83	245	139	137	137
query84	290	71	72	71
query85	2284	292	286	286
query86	500	305	293	293
query87	4471	4261	4302	4261
query88	5352	2329	2362	2329
query89	446	286	287	286
query90	2060	181	177	177
query91	175	137	138	137
query92	63	48	51	48
query93	5263	550	533	533
query94	963	283	271	271
query95	334	247	243	243
query96	616	278	272	272
query97	3315	3144	3116	3116
query98	216	199	190	190
query99	1837	1312	1303	1303
Total cold run time: 315789 ms
Total hot run time: 189256 ms

@BiteTheDDDDt BiteTheDDDDt merged commit 32e8d18 into branch-3.0 Nov 27, 2024
@github-actions github-actions Bot deleted the auto-pick-44354-branch-3.0 branch November 27, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants