Skip to content

Conversation

@airborne12
Copy link
Member

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jun 20, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@airborne12
Copy link
Member Author

run buildall

Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 20, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@zzzxl1993 zzzxl1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 56.37% (15052/26700)
Line Coverage 45.15% (134676/298302)
Region Coverage 44.29% (67714/152897)
Branch Coverage 38.89% (34753/89368)

@doris-robot
Copy link

TPC-H: Total hot run time: 33826 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 05c5511c2f286d7cf18b1255555f0a2c385b137b, data reload: false

------ Round 1 ----------------------------------
q1	17624	5190	5049	5049
q2	1935	286	189	189
q3	10310	1355	729	729
q4	10243	1007	531	531
q5	7643	2363	2326	2326
q6	183	163	131	131
q7	989	741	597	597
q8	9314	1202	1086	1086
q9	6960	5183	5124	5124
q10	6961	2385	1965	1965
q11	493	286	273	273
q12	346	357	223	223
q13	17772	3675	3114	3114
q14	232	232	223	223
q15	563	476	478	476
q16	428	436	374	374
q17	609	872	386	386
q18	7591	7311	6951	6951
q19	1589	947	522	522
q20	332	333	226	226
q21	4057	3184	2359	2359
q22	1066	972	980	972
Total cold run time: 107240 ms
Total hot run time: 33826 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5258	5128	5048	5048
q2	246	318	218	218
q3	2165	2626	2296	2296
q4	1347	1784	1327	1327
q5	4209	4071	4399	4071
q6	212	169	128	128
q7	2034	1964	1732	1732
q8	2549	2669	2589	2589
q9	7148	7084	7128	7084
q10	3085	3248	2864	2864
q11	591	537	499	499
q12	688	754	609	609
q13	3580	3975	3300	3300
q14	290	293	275	275
q15	514	501	473	473
q16	449	501	433	433
q17	1162	1486	1393	1393
q18	7388	7181	7004	7004
q19	754	771	840	771
q20	1918	2073	1825	1825
q21	4746	4388	4300	4300
q22	1013	1007	978	978
Total cold run time: 51346 ms
Total hot run time: 49217 ms

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 61.12% (16058/26274)
Line Coverage 50.62% (150910/298140)
Region Coverage 47.97% (86288/179868)
Branch Coverage 41.43% (42327/102174)

@doris-robot
Copy link

TPC-DS: Total hot run time: 186819 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 05c5511c2f286d7cf18b1255555f0a2c385b137b, data reload: false

query1	982	387	409	387
query2	6561	1797	1809	1797
query3	6752	223	222	222
query4	26101	23836	23320	23320
query5	4363	645	505	505
query6	322	223	214	214
query7	4649	513	324	324
query8	265	230	216	216
query9	8633	2672	2646	2646
query10	482	337	294	294
query11	15526	15162	15121	15121
query12	170	113	106	106
query13	1655	537	429	429
query14	9503	6320	6317	6317
query15	206	209	182	182
query16	7478	631	488	488
query17	1207	732	592	592
query18	2077	430	318	318
query19	211	195	164	164
query20	122	116	118	116
query21	225	133	114	114
query22	3982	4033	4122	4033
query23	33999	33303	33107	33107
query24	8460	2392	2396	2392
query25	531	469	399	399
query26	1225	270	156	156
query27	2717	520	344	344
query28	4320	2125	2113	2113
query29	767	548	442	442
query30	277	222	197	197
query31	945	825	798	798
query32	76	64	65	64
query33	549	382	300	300
query34	832	860	532	532
query35	803	841	733	733
query36	938	972	904	904
query37	117	99	76	76
query38	4188	4157	4057	4057
query39	1489	1445	1442	1442
query40	209	119	107	107
query41	63	60	57	57
query42	122	109	109	109
query43	506	508	457	457
query44	1327	824	823	823
query45	183	172	167	167
query46	869	1037	633	633
query47	1740	1779	1709	1709
query48	381	436	318	318
query49	735	503	439	439
query50	689	680	416	416
query51	4141	4235	4127	4127
query52	117	112	101	101
query53	237	262	181	181
query54	581	574	501	501
query55	85	84	86	84
query56	341	320	273	273
query57	1178	1196	1106	1106
query58	272	264	253	253
query59	2611	2607	2589	2589
query60	318	312	299	299
query61	154	126	126	126
query62	820	695	697	695
query63	229	216	195	195
query64	4313	995	674	674
query65	4264	4172	4162	4162
query66	1103	415	326	326
query67	15654	15519	15439	15439
query68	8498	904	541	541
query69	471	296	276	276
query70	1173	1124	1060	1060
query71	454	334	298	298
query72	5701	4724	4853	4724
query73	745	662	364	364
query74	8877	9147	8868	8868
query75	3968	3179	2702	2702
query76	3727	1204	788	788
query77	797	387	295	295
query78	10066	10453	9334	9334
query79	2116	905	579	579
query80	612	523	445	445
query81	503	264	228	228
query82	499	137	104	104
query83	263	255	239	239
query84	253	111	89	89
query85	864	411	332	332
query86	384	299	290	290
query87	4403	4451	4374	4374
query88	3556	2281	2261	2261
query89	387	320	302	302
query90	1863	221	220	220
query91	144	140	112	112
query92	79	60	59	59
query93	1796	986	596	596
query94	634	408	304	304
query95	383	303	290	290
query96	498	587	287	287
query97	2709	2720	2664	2664
query98	239	207	210	207
query99	1343	1420	1260	1260
Total cold run time: 274952 ms
Total hot run time: 186819 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.35 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 05c5511c2f286d7cf18b1255555f0a2c385b137b, data reload: false

query1	0.03	0.04	0.02
query2	0.07	0.04	0.03
query3	0.23	0.07	0.06
query4	1.62	0.10	0.11
query5	0.43	0.41	0.40
query6	1.18	0.67	0.68
query7	0.03	0.02	0.02
query8	0.04	0.04	0.04
query9	0.57	0.52	0.51
query10	0.56	0.58	0.58
query11	0.16	0.11	0.11
query12	0.15	0.11	0.11
query13	0.64	0.61	0.62
query14	0.81	0.83	0.83
query15	0.92	0.86	0.87
query16	0.40	0.41	0.41
query17	1.05	1.05	1.05
query18	0.22	0.21	0.21
query19	1.96	1.95	1.92
query20	0.01	0.02	0.01
query21	15.41	0.91	0.54
query22	0.75	1.24	0.59
query23	14.95	1.38	0.66
query24	6.74	2.48	0.54
query25	0.47	0.08	0.15
query26	0.53	0.16	0.13
query27	0.06	0.05	0.05
query28	10.07	0.94	0.47
query29	12.65	4.07	3.33
query30	0.25	0.09	0.06
query31	2.82	0.62	0.40
query32	3.25	0.56	0.48
query33	3.07	3.10	3.13
query34	16.10	5.37	4.73
query35	4.83	4.82	4.80
query36	0.69	0.50	0.51
query37	0.09	0.07	0.07
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.16	0.14	0.14
query41	0.09	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.2 s
Total hot run time: 29.35 s

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 61.12% (16058/26274)
Line Coverage 50.62% (150910/298140)
Region Coverage 47.97% (86288/179868)
Branch Coverage 41.43% (42327/102174)

@airborne12 airborne12 merged commit 7bd3d63 into apache:master Jun 20, 2025
24 of 28 checks passed
@airborne12 airborne12 deleted the remove-match-predicate branch June 20, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants