-
Notifications
You must be signed in to change notification settings - Fork 3.6k
[Fix](function) Fix wrong nullable of floor/ceil functions #57238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
ClickBench: Total hot run time: 27.43 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
before:
```sql
mysql> select minute_ceil(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)), nullable(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0))));
ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.3)[INTERNAL_ERROR]Column VectorizedFnCall[minute_ceil](arguments=DateTimeV2(0), VectorizedFnCall[nullable](arguments=DateTimeV2(0),return=Nullable(DateTimeV2(0))),return=Nullable(DateTimeV2(0))) in block is not compatible with its column type :Const(DATETIMEV2), data type :Nullable(DateTimeV2(0)), error: Column type Const(DATETIMEV2) is not compatible with data type Nullable(DateTimeV2(0))
```
now:
```sql
mysql> select minute_ceil(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)), nullable(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0))));
+-------------------------------------------------------------------------------------------------------------------+
| minute_ceil(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)), nullable(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)))) |
+-------------------------------------------------------------------------------------------------------------------+
| 2021-12-31 12:23:34 |
+-------------------------------------------------------------------------------------------------------------------+
```
) before: ```sql mysql> select minute_ceil(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)), nullable(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)))); ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.3)[INTERNAL_ERROR]Column VectorizedFnCall[minute_ceil](arguments=DateTimeV2(0), VectorizedFnCall[nullable](arguments=DateTimeV2(0),return=Nullable(DateTimeV2(0))),return=Nullable(DateTimeV2(0))) in block is not compatible with its column type :Const(DATETIMEV2), data type :Nullable(DateTimeV2(0)), error: Column type Const(DATETIMEV2) is not compatible with data type Nullable(DateTimeV2(0)) ``` now: ```sql mysql> select minute_ceil(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)), nullable(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)))); +-------------------------------------------------------------------------------------------------------------------+ | minute_ceil(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)), nullable(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)))) | +-------------------------------------------------------------------------------------------------------------------+ | 2021-12-31 12:23:34 | +-------------------------------------------------------------------------------------------------------------------+ ```
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
before:
now:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)