Skip to content

Conversation

@zclllyybb
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

before:

mysql> select minute_ceil(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)), nullable(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0))));
ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.3)[INTERNAL_ERROR]Column VectorizedFnCall[minute_ceil](arguments=DateTimeV2(0), VectorizedFnCall[nullable](arguments=DateTimeV2(0),return=Nullable(DateTimeV2(0))),return=Nullable(DateTimeV2(0))) in block is not compatible with its column type :Const(DATETIMEV2), data type :Nullable(DateTimeV2(0)), error: Column type Const(DATETIMEV2) is not compatible with data type Nullable(DateTimeV2(0))

now:

mysql> select minute_ceil(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)), nullable(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0))));
+-------------------------------------------------------------------------------------------------------------------+
| minute_ceil(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)), nullable(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)))) |
+-------------------------------------------------------------------------------------------------------------------+
| 2021-12-31 12:23:34                                                                                               |
+-------------------------------------------------------------------------------------------------------------------+

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Oct 22, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zclllyybb
Copy link
Contributor Author

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 22, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

ClickBench: Total hot run time: 27.43 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b8486c8abbf0144be80c6e21d609f68d38258310, data reload: false

query1	0.06	0.05	0.04
query2	0.10	0.06	0.05
query3	0.26	0.09	0.08
query4	1.61	0.13	0.12
query5	0.29	0.26	0.26
query6	1.17	0.66	0.65
query7	0.04	0.03	0.03
query8	0.06	0.05	0.05
query9	0.63	0.53	0.52
query10	0.60	0.59	0.58
query11	0.18	0.11	0.12
query12	0.15	0.13	0.12
query13	0.62	0.62	0.59
query14	1.01	1.02	1.02
query15	0.87	0.85	0.86
query16	0.40	0.39	0.38
query17	1.03	1.04	1.04
query18	0.22	0.21	0.20
query19	1.97	1.74	1.88
query20	0.01	0.01	0.02
query21	15.42	0.19	0.13
query22	5.05	0.07	0.06
query23	15.66	0.27	0.10
query24	3.24	0.86	0.30
query25	0.09	0.06	0.06
query26	0.15	0.13	0.14
query27	0.07	0.06	0.05
query28	4.39	1.16	0.94
query29	12.57	3.95	3.28
query30	0.29	0.13	0.12
query31	2.82	0.60	0.38
query32	3.24	0.55	0.47
query33	3.02	3.15	3.05
query34	15.91	5.16	4.51
query35	4.62	4.65	4.55
query36	0.68	0.51	0.49
query37	0.11	0.07	0.08
query38	0.06	0.05	0.04
query39	0.04	0.04	0.03
query40	0.18	0.15	0.14
query41	0.09	0.04	0.03
query42	0.05	0.04	0.03
query43	0.05	0.03	0.03
Total cold run time: 99.08 s
Total hot run time: 27.43 s

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 50.00% (1/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.64% (17933/34065)
Line Coverage 37.89% (162703/429459)
Region Coverage 32.31% (124181/384318)
Branch Coverage 33.70% (54375/161340)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.43% (23891/33446)
Line Coverage 57.85% (248597/429752)
Region Coverage 53.02% (206529/389567)
Branch Coverage 54.77% (88905/162315)

@zclllyybb zclllyybb merged commit dce846d into apache:master Oct 22, 2025
30 of 31 checks passed
@zclllyybb zclllyybb deleted the ceil_null branch October 22, 2025 12:52
github-actions bot pushed a commit that referenced this pull request Oct 22, 2025
before:
```sql
mysql> select minute_ceil(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)), nullable(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0))));
ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.3)[INTERNAL_ERROR]Column VectorizedFnCall[minute_ceil](arguments=DateTimeV2(0), VectorizedFnCall[nullable](arguments=DateTimeV2(0),return=Nullable(DateTimeV2(0))),return=Nullable(DateTimeV2(0))) in block is not compatible with its column type :Const(DATETIMEV2), data type :Nullable(DateTimeV2(0)), error: Column type Const(DATETIMEV2) is not compatible with data type Nullable(DateTimeV2(0))
```
now:
```sql
mysql> select minute_ceil(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)), nullable(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0))));
+-------------------------------------------------------------------------------------------------------------------+
| minute_ceil(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)), nullable(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)))) |
+-------------------------------------------------------------------------------------------------------------------+
| 2021-12-31 12:23:34                                                                                               |
+-------------------------------------------------------------------------------------------------------------------+

```
yiguolei pushed a commit that referenced this pull request Oct 23, 2025
…#57238 (#57244)

Cherry-picked from #57238

Co-authored-by: zclllyybb <zhaochangle@selectdb.com>
dwdwqfwe pushed a commit to dwdwqfwe/doris that referenced this pull request Oct 24, 2025
)

before:
```sql
mysql> select minute_ceil(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)), nullable(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0))));
ERROR 1105 (HY000): errCode = 2, detailMessage = (10.16.10.3)[INTERNAL_ERROR]Column VectorizedFnCall[minute_ceil](arguments=DateTimeV2(0), VectorizedFnCall[nullable](arguments=DateTimeV2(0),return=Nullable(DateTimeV2(0))),return=Nullable(DateTimeV2(0))) in block is not compatible with its column type :Const(DATETIMEV2), data type :Nullable(DateTimeV2(0)), error: Column type Const(DATETIMEV2) is not compatible with data type Nullable(DateTimeV2(0))
```
now:
```sql
mysql> select minute_ceil(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)), nullable(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0))));
+-------------------------------------------------------------------------------------------------------------------+
| minute_ceil(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)), nullable(CAST('2021-12-31 12:23:34' AS DATETIMEV2(0)))) |
+-------------------------------------------------------------------------------------------------------------------+
| 2021-12-31 12:23:34                                                                                               |
+-------------------------------------------------------------------------------------------------------------------+

```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/4.0.1-merged p0_w reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants