[test](be) Cover parquet conjunct local filter#63705
Merged
Merged
Conversation
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary: ParquetReader::_read_filter_columns evaluated localized filters through FileLocalFilter::predicates, while the localized filter expression is stored in FileLocalFilter::conjunct. This changes the lazy filter path to execute the conjunct and intersect its result with the selection vector.
### Release note
None
### Check List (For Author)
- Test: Manual test
- Ran git diff --check. build-support/clang-format.sh and build-support/check-format.sh could not run because clang-format/llvm@16 is not installed in this environment. Compile test was not run because the existing compile_commands.json points to unavailable /mnt paths and ninja is not installed.
- Behavior changed: No
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary: NewParquetReaderTest only populated FileLocalFilter::predicates for local predicate filtering. Parquet row group pruning still uses predicates, while row filtering now uses conjunct, so the tests need to populate both with matching semantics.
### Release note
None
### Check List (For Author)
- Test: Manual test
- Ran git diff --check. ./run-be-ut.sh --run '--filter=NewParquetReaderTest.*' could not run because JAVA_HOME points to JDK 11 and JDK_17 is not set. build-support/check-format.sh could not run because clang-format is not installed.
- Behavior changed: No
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary: ParquetReader now calls VExprContext::execute_filter directly, but parquet_reader.cpp only had the forward declaration from vexpr_fwd.h. Include vexpr_context.h so the method definition is visible.
### Release note
None
### Check List (For Author)
- Test: Manual test
- Ran git diff --check.
- Behavior changed: No
- Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Gabriel39
merged commit e65a09e
into
apache:refact_reader_branch
15 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary: NewParquetReaderTest only populated FileLocalFilter::predicates for local predicate filtering. Parquet row group pruning still uses predicates, while row filtering now uses conjunct, so the tests need to populate both with matching semantics.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)