branch-4.0: [fix](fe) Bound length in MysqlProto.readLenEncodedString #63604#64058
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.0: [fix](fe) Bound length in MysqlProto.readLenEncodedString #63604#64058github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
### What problem does this PR solve? Issue Number: close #63603 Problem Summary: `MysqlProto.readLenEncodedString` reads a length-encoded integer and passes it straight to `new byte[(int) length]` with no bound. The length is fully attacker-controlled (a `0xFE` lead byte carries an 8-byte value), and it is read before authentication from `MysqlAuthPacket.readFrom` (the auth-response field at `MysqlAuthPacket.java:93` and the connection-attributes loop at `MysqlAuthPacket.java:110-118`). A small handshake response can therefore request a ~2 GiB allocation, and a length with the high bit set casts to a negative size (`NegativeArraySizeException`). This PR rejects a length that is negative or larger than the bytes remaining in the buffer before allocating. A well-formed length-encoded string's payload always fits in the remaining buffer, so valid input is unaffected. One guard covers both reach paths.
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
|
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #63604