Mavenized query-parse subproject #1

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@antoniogarrote

Now the project can be built using Maven and tests are passing.

Added pom.xml file, changes in directory structure and minor code changes.

@Humbedooh
Member

Throwing in a comment on a random PR to make sure the project gets it on their ML. Apologies.

@asfgit asfgit pushed a commit that closed this pull request Oct 8, 2014
@adityakishore adityakishore Updating projects version to 0.7.0-incubating-SNAPSHOT.
The following pull requests have been either been merged or closed as of this release.

closes #1  (via 207f2e4)
closes #3  (*No longer relevant*)
closes #8  (via cb3132a)
closes #11 (via 727adb7, a73512d)
closes #12 (*Issue fixed via DRILL-88*)
closes #13 (*Closed as Won't Fix*)
closes #14 (via f0be80d)
closes #17 (via a38856c)
closes #35 (via 741aab0)
closes #60 (via 1648195)
closes #64 (Resolved as part of other function merges)
closes #65 (via 28dd76a)
closes #66 (via 4862b2b)
closes #67 (via 2ca9c90)
cba8423
@asfgit asfgit closed this in cba8423 Oct 8, 2014
@dsbos dsbos added a commit to dsbos/drill that referenced this pull request Oct 29, 2015
@dsbos dsbos 2288: Pt. ? Core: Changed HBase test table #1's # of regions from 1 t…
…o 2. [HBaseTestsSuite]
c639abb
@dsbos dsbos added a commit to dsbos/drill that referenced this pull request Nov 1, 2015
@dsbos dsbos 2288: Pt. 1? Core: Changed HBase test table #1's # of regions from 1 …
…to 2. [HBaseTestsSuite]
6036c9e
@dsbos dsbos added a commit to dsbos/drill that referenced this pull request Nov 1, 2015
@dsbos dsbos 2288: Pt. 1 Core: Changed HBase test table #1's # of regions from 1 t…
…o 2. [HBaseTestsSuite]
a7a7be2
@dsbos dsbos added a commit to dsbos/drill that referenced this pull request Nov 1, 2015
@dsbos dsbos 2288: Pt. 1 Core: Changed HBase test table #1's # of regions from 1 t…
…o 2. [HBaseTestsSuite]
545ace5
@dsbos dsbos added a commit to dsbos/drill that referenced this pull request Nov 2, 2015
@dsbos dsbos 2288: Pt. 1 Core: Changed HBase test table #1's # of regions from 1 t…
…o 2. [HBaseTestsSuite]

Also added TODO(DRILL-3954) comment about # of regions.
3de5ea5
@dsbos dsbos added a commit to dsbos/drill that referenced this pull request Nov 4, 2015
@dsbos dsbos 2288: Pt. 1 Core: Changed HBase test table #1's # of regions from 1 t…
…o 2. [HBaseTestsSuite]

Also added TODO(DRILL-3954) comment about # of regions.
994a49c
@dsbos dsbos added a commit to dsbos/drill that referenced this pull request Nov 6, 2015
@dsbos dsbos DRILL-2288: Fix ScanBatch violation of IterOutcome protocol and downs…
…tream chain of bugs.

Increments:

2288:  Pt. 1 Core:  Added unit test.  [Drill2288GetColumnsMetadataWhenNoRowsTest, empty.json]

2288:  Pt. 1 Core:  Changed HBase test table #1's # of regions from 1 to 2.  [HBaseTestsSuite]

Also added TODO(DRILL-3954) comment about # of regions.

2288:  Pt. 2 Core:  Documented IterOutcome much more clearly.  [RecordBatch]

Also edited some related Javadoc.

2288:  Pt. 2 Hyg.:  Edited doc., added @Override, etc.  [AbstractRecordBatch, RecordBatch]

Purged unused SetupOutcome.
Added @Override.
Edited comments.
Fix some comments to doc. comments.

2288:  Pt. 3 Core&Hyg.:  Added validation of IterOutcome sequence.  [IteratorValidatorBatchIterator]

Also:
Renamed internal members for clarity.
Added comments.

2288:  Pt. 4 Core:  Fixed a NONE -> OK_NEW_SCHEMA in ScanBatch.next().  [ScanBatch]

(With nearby comments.)

2288:  Pt. 4 Hyg.:  Edited comments, reordered, whitespace.  [ScanBatch]

Reordered
Added comments.
Aligned.

2288:  Pt. 4 Core+:  Fixed UnionAllRecordBatch to receive IterOutcome sequence right.  (3659)  [UnionAllRecordBatch]

2288:  Pt. 5 Core:  Fixed ScanBatch.Mutator.isNewSchema() to stop spurious "new schema" reports (fix short-circuit OR, to call resetting method right).  [ScanBatch]

2288:  Pt. 5 Hyg.:  Renamed, edited comments, reordered.  [ScanBatch, SchemaChangeCallBack, AbstractSingleRecordBatch]

Renamed getSchemaChange -> getSchemaChangedAndReset.
Renamed schemaChange -> schemaChanged.
Added doc. comments.
Aligned.

2288:  Pt. 6 Core:  Avoided dummy Null.IntVec. column in JsonReader when not needed (MapWriter.isEmptyMap()).  [JsonReader, 3 vector files]

2288:  Pt. 6 Hyg.:  Edited comments, message.  Fixed message formatting.  [RecordReader, JSONFormatPlugin, JSONRecordReader, AbstractMapVector, JsonReader]

Fixed message formatting.
Edited comments.
Edited message.
Fixed spurious line break.

2288:  Pt. 7 Core:  Added column families in HBaseRecordReader* to avoid dummy Null.IntVec. clash.  [HBaseRecordReader]

2288:  Pt. 8 Core.1:  Cleared recordCount in OrderedPartitionRecordBatch.innerNext().  [OrderedPartitionRecordBatch]

2288:  Pt. 8 Core.2:  Cleared recordCount in ProjectRecordBatch.innerNext.  [ProjectRecordBatch]

2288:  Pt. 8 Core.3:  Cleared recordCount in TopNBatch.innerNext.  [TopNBatch]

2288:  Pt. 9 Core:  Had UnorderedReceiverBatch reset RecordBatchLoader's record count.  [UnorderedReceiverBatch, RecordBatchLoader]

2288:  Pt. 9 Hyg.:  Added comments.  [RecordBatchLoader]

2288:  Pt. 10 Core:  Worked around mismatched map child vectors in MapVector.getObject().  [MapVector]

2288:  Pt. 11 Core:  Added OK_NEW_SCHEMA schema comparison for HashAgg.  [HashAggTemplate]

2288:  Pt. 12 Core:  Fixed memory leak in BaseTestQuery's printing.

Fixed bad skipping of RecordBatchLoader.clear(...) and
QueryDataBatch.load(...) for zero-row batches in printResult(...).

Also, dropped suppression of call to
VectorUtil.showVectorAccessibleContent(...) (so zero-row batches are
as visible as others).

2288:  Pt. 13 Core:  Fixed test that used unhandled periods in column alias identifiers.

2288:  Misc.:  Added # of rows to showVectorAccessibleContent's output.  [VectorUtil]

2288:  Misc.:  Added simple/partial toString() [VectorContainer, AbstractRecordReader, JSONRecordReader, BaseValueVector, FieldSelection, AbstractBaseWriter]

2288:  Misc. Hyg.:  Added doc. comments to VectorContainer.  [VectorContainer]

2288:  Misc. Hyg.:  Edited comment.  [DrillStringUtils]

2288:  Misc. Hyg.:  Clarified message for unhandled identifier containing period.

2288:  Pt. 3 Core&Hyg. Upd.:  Added schema comparison result to logging.  [IteratorValidatorBatchIterator]

2288:  Pt. 7 Core Upd.:  Handled HBase columns too re NullableIntVectors.  [HBaseRecordReader, TestTableGenerator, TestHBaseFilterPushDown]

Created map-child vectors for requested columns.
Added unit test method testDummyColumnsAreAvoided, adding new row to test table,
updated some row counts.

2288:  Pt. 7 Hyg. Upd.:  Edited comment.  [HBaseRecordReader]

2288:  Pt. 11 Core Upd.:  REVERTED all of bad OK_NEW_SCHEMA schema comparison for HashAgg.  [HashAggTemplate]

This reverts commit 0939660.

2288:  Pt. 6 Core Upd.:  Added isEmptyMap override in new (just-rebased-in) PromotableWriter.  [PromotableWriter]

Adjusted definition and default implementation of isEmptyMap (to handle MongoDB
storage plugin's use of JsonReader).

2288:  Pt. 6 Hyg. Upd.:  Purged old atLeastOneWrite flag.  [JsonReader]

2288:  Pt. 14:  Disabled newly dying test testNestedFlatten().
3d39f7a
@hnfgns hnfgns referenced this pull request in hnfgns/incubator-drill Nov 6, 2015
@dsbos @hnfgns dsbos + hnfgns DRILL-2288: Fix ScanBatch violation of IterOutcome protocol and downs…
…tream chain of bugs.

Increments:

2288:  Pt. 1 Core:  Added unit test.  [Drill2288GetColumnsMetadataWhenNoRowsTest, empty.json]

2288:  Pt. 1 Core:  Changed HBase test table #1's # of regions from 1 to 2.  [HBaseTestsSuite]

Also added TODO(DRILL-3954) comment about # of regions.

2288:  Pt. 2 Core:  Documented IterOutcome much more clearly.  [RecordBatch]

Also edited some related Javadoc.

2288:  Pt. 2 Hyg.:  Edited doc., added @Override, etc.  [AbstractRecordBatch, RecordBatch]

Purged unused SetupOutcome.
Added @Override.
Edited comments.
Fix some comments to doc. comments.

2288:  Pt. 3 Core&Hyg.:  Added validation of IterOutcome sequence.  [IteratorValidatorBatchIterator]

Also:
Renamed internal members for clarity.
Added comments.

2288:  Pt. 4 Core:  Fixed a NONE -> OK_NEW_SCHEMA in ScanBatch.next().  [ScanBatch]

(With nearby comments.)

2288:  Pt. 4 Hyg.:  Edited comments, reordered, whitespace.  [ScanBatch]

Reordered
Added comments.
Aligned.

2288:  Pt. 4 Core+:  Fixed UnionAllRecordBatch to receive IterOutcome sequence right.  (3659)  [UnionAllRecordBatch]

2288:  Pt. 5 Core:  Fixed ScanBatch.Mutator.isNewSchema() to stop spurious "new schema" reports (fix short-circuit OR, to call resetting method right).  [ScanBatch]

2288:  Pt. 5 Hyg.:  Renamed, edited comments, reordered.  [ScanBatch, SchemaChangeCallBack, AbstractSingleRecordBatch]

Renamed getSchemaChange -> getSchemaChangedAndReset.
Renamed schemaChange -> schemaChanged.
Added doc. comments.
Aligned.

2288:  Pt. 6 Core:  Avoided dummy Null.IntVec. column in JsonReader when not needed (MapWriter.isEmptyMap()).  [JsonReader, 3 vector files]

2288:  Pt. 6 Hyg.:  Edited comments, message.  Fixed message formatting.  [RecordReader, JSONFormatPlugin, JSONRecordReader, AbstractMapVector, JsonReader]

Fixed message formatting.
Edited comments.
Edited message.
Fixed spurious line break.

2288:  Pt. 7 Core:  Added column families in HBaseRecordReader* to avoid dummy Null.IntVec. clash.  [HBaseRecordReader]

2288:  Pt. 8 Core.1:  Cleared recordCount in OrderedPartitionRecordBatch.innerNext().  [OrderedPartitionRecordBatch]

2288:  Pt. 8 Core.2:  Cleared recordCount in ProjectRecordBatch.innerNext.  [ProjectRecordBatch]

2288:  Pt. 8 Core.3:  Cleared recordCount in TopNBatch.innerNext.  [TopNBatch]

2288:  Pt. 9 Core:  Had UnorderedReceiverBatch reset RecordBatchLoader's record count.  [UnorderedReceiverBatch, RecordBatchLoader]

2288:  Pt. 9 Hyg.:  Added comments.  [RecordBatchLoader]

2288:  Pt. 10 Core:  Worked around mismatched map child vectors in MapVector.getObject().  [MapVector]

2288:  Pt. 11 Core:  Added OK_NEW_SCHEMA schema comparison for HashAgg.  [HashAggTemplate]

2288:  Pt. 12 Core:  Fixed memory leak in BaseTestQuery's printing.

Fixed bad skipping of RecordBatchLoader.clear(...) and
QueryDataBatch.load(...) for zero-row batches in printResult(...).

Also, dropped suppression of call to
VectorUtil.showVectorAccessibleContent(...) (so zero-row batches are
as visible as others).

2288:  Pt. 13 Core:  Fixed test that used unhandled periods in column alias identifiers.

2288:  Misc.:  Added # of rows to showVectorAccessibleContent's output.  [VectorUtil]

2288:  Misc.:  Added simple/partial toString() [VectorContainer, AbstractRecordReader, JSONRecordReader, BaseValueVector, FieldSelection, AbstractBaseWriter]

2288:  Misc. Hyg.:  Added doc. comments to VectorContainer.  [VectorContainer]

2288:  Misc. Hyg.:  Edited comment.  [DrillStringUtils]

2288:  Misc. Hyg.:  Clarified message for unhandled identifier containing period.

2288:  Pt. 3 Core&Hyg. Upd.:  Added schema comparison result to logging.  [IteratorValidatorBatchIterator]

2288:  Pt. 7 Core Upd.:  Handled HBase columns too re NullableIntVectors.  [HBaseRecordReader, TestTableGenerator, TestHBaseFilterPushDown]

Created map-child vectors for requested columns.
Added unit test method testDummyColumnsAreAvoided, adding new row to test table,
updated some row counts.

2288:  Pt. 7 Hyg. Upd.:  Edited comment.  [HBaseRecordReader]

2288:  Pt. 11 Core Upd.:  REVERTED all of bad OK_NEW_SCHEMA schema comparison for HashAgg.  [HashAggTemplate]

This reverts commit 0939660.

2288:  Pt. 6 Core Upd.:  Added isEmptyMap override in new (just-rebased-in) PromotableWriter.  [PromotableWriter]

Adjusted definition and default implementation of isEmptyMap (to handle MongoDB
storage plugin's use of JsonReader).

2288:  Pt. 6 Hyg. Upd.:  Purged old atLeastOneWrite flag.  [JsonReader]

2288:  Pt. 14:  Disabled newly dying test testNestedFlatten().
c000cd5
@hnfgns hnfgns referenced this pull request in hnfgns/incubator-drill Nov 9, 2015
@dsbos @hnfgns dsbos + hnfgns DRILL-2288: Fix ScanBatch violation of IterOutcome protocol and downs…
…tream chain of bugs.

Increments:

2288:  Pt. 1 Core:  Added unit test.  [Drill2288GetColumnsMetadataWhenNoRowsTest, empty.json]

2288:  Pt. 1 Core:  Changed HBase test table #1's # of regions from 1 to 2.  [HBaseTestsSuite]

Also added TODO(DRILL-3954) comment about # of regions.

2288:  Pt. 2 Core:  Documented IterOutcome much more clearly.  [RecordBatch]

Also edited some related Javadoc.

2288:  Pt. 2 Hyg.:  Edited doc., added @Override, etc.  [AbstractRecordBatch, RecordBatch]

Purged unused SetupOutcome.
Added @Override.
Edited comments.
Fix some comments to doc. comments.

2288:  Pt. 3 Core&Hyg.:  Added validation of IterOutcome sequence.  [IteratorValidatorBatchIterator]

Also:
Renamed internal members for clarity.
Added comments.

2288:  Pt. 4 Core:  Fixed a NONE -> OK_NEW_SCHEMA in ScanBatch.next().  [ScanBatch]

(With nearby comments.)

2288:  Pt. 4 Hyg.:  Edited comments, reordered, whitespace.  [ScanBatch]

Reordered
Added comments.
Aligned.

2288:  Pt. 4 Core+:  Fixed UnionAllRecordBatch to receive IterOutcome sequence right.  (3659)  [UnionAllRecordBatch]

2288:  Pt. 5 Core:  Fixed ScanBatch.Mutator.isNewSchema() to stop spurious "new schema" reports (fix short-circuit OR, to call resetting method right).  [ScanBatch]

2288:  Pt. 5 Hyg.:  Renamed, edited comments, reordered.  [ScanBatch, SchemaChangeCallBack, AbstractSingleRecordBatch]

Renamed getSchemaChange -> getSchemaChangedAndReset.
Renamed schemaChange -> schemaChanged.
Added doc. comments.
Aligned.

2288:  Pt. 6 Core:  Avoided dummy Null.IntVec. column in JsonReader when not needed (MapWriter.isEmptyMap()).  [JsonReader, 3 vector files]

2288:  Pt. 6 Hyg.:  Edited comments, message.  Fixed message formatting.  [RecordReader, JSONFormatPlugin, JSONRecordReader, AbstractMapVector, JsonReader]

Fixed message formatting.
Edited comments.
Edited message.
Fixed spurious line break.

2288:  Pt. 7 Core:  Added column families in HBaseRecordReader* to avoid dummy Null.IntVec. clash.  [HBaseRecordReader]

2288:  Pt. 8 Core.1:  Cleared recordCount in OrderedPartitionRecordBatch.innerNext().  [OrderedPartitionRecordBatch]

2288:  Pt. 8 Core.2:  Cleared recordCount in ProjectRecordBatch.innerNext.  [ProjectRecordBatch]

2288:  Pt. 8 Core.3:  Cleared recordCount in TopNBatch.innerNext.  [TopNBatch]

2288:  Pt. 9 Core:  Had UnorderedReceiverBatch reset RecordBatchLoader's record count.  [UnorderedReceiverBatch, RecordBatchLoader]

2288:  Pt. 9 Hyg.:  Added comments.  [RecordBatchLoader]

2288:  Pt. 10 Core:  Worked around mismatched map child vectors in MapVector.getObject().  [MapVector]

2288:  Pt. 11 Core:  Added OK_NEW_SCHEMA schema comparison for HashAgg.  [HashAggTemplate]

2288:  Pt. 12 Core:  Fixed memory leak in BaseTestQuery's printing.

Fixed bad skipping of RecordBatchLoader.clear(...) and
QueryDataBatch.load(...) for zero-row batches in printResult(...).

Also, dropped suppression of call to
VectorUtil.showVectorAccessibleContent(...) (so zero-row batches are
as visible as others).

2288:  Pt. 13 Core:  Fixed test that used unhandled periods in column alias identifiers.

2288:  Misc.:  Added # of rows to showVectorAccessibleContent's output.  [VectorUtil]

2288:  Misc.:  Added simple/partial toString() [VectorContainer, AbstractRecordReader, JSONRecordReader, BaseValueVector, FieldSelection, AbstractBaseWriter]

2288:  Misc. Hyg.:  Added doc. comments to VectorContainer.  [VectorContainer]

2288:  Misc. Hyg.:  Edited comment.  [DrillStringUtils]

2288:  Misc. Hyg.:  Clarified message for unhandled identifier containing period.

2288:  Pt. 3 Core&Hyg. Upd.:  Added schema comparison result to logging.  [IteratorValidatorBatchIterator]

2288:  Pt. 7 Core Upd.:  Handled HBase columns too re NullableIntVectors.  [HBaseRecordReader, TestTableGenerator, TestHBaseFilterPushDown]

Created map-child vectors for requested columns.
Added unit test method testDummyColumnsAreAvoided, adding new row to test table,
updated some row counts.

2288:  Pt. 7 Hyg. Upd.:  Edited comment.  [HBaseRecordReader]

2288:  Pt. 11 Core Upd.:  REVERTED all of bad OK_NEW_SCHEMA schema comparison for HashAgg.  [HashAggTemplate]

This reverts commit 0939660.

2288:  Pt. 6 Core Upd.:  Added isEmptyMap override in new (just-rebased-in) PromotableWriter.  [PromotableWriter]

Adjusted definition and default implementation of isEmptyMap (to handle MongoDB
storage plugin's use of JsonReader).

2288:  Pt. 6 Hyg. Upd.:  Purged old atLeastOneWrite flag.  [JsonReader]

2288:  Pt. 14:  Disabled newly dying test testNestedFlatten().
a0be3ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment