Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRILL-6549: batch sizing for nested loop join #1363

Closed
wants to merge 1 commit into from

Conversation

@ppadma
Copy link
Contributor

commented Jul 5, 2018

No description provided.

@ppadma

This comment has been minimized.

Copy link
Contributor Author

commented Jul 5, 2018

@sohami @Ben-Zvi can one of you review this ? Pretty straightforward changes.

@Ben-Zvi
Ben-Zvi approved these changes Jul 7, 2018
Copy link
Contributor

left a comment

+1 , nice work , changes are indeed straightforward.

ExpressionPosition.UNKNOWN);

NestedLoopJoinPOP nestedLoopJoin = new NestedLoopJoinPOP(null, null, JoinRelType.INNER, functionCallExpr);
mockOpContext(nestedLoopJoin, initReservation, maxAllocation);

This comment has been minimized.

Copy link
@Ben-Zvi

Ben-Zvi Jul 7, 2018

Contributor

Just a comment: This test calls mockOpContext(), while the other new NLJ tests don't. I tested all with and without this call, and it seems to make no difference anyway ....

arina-ielchiieva added a commit to arina-ielchiieva/drill that referenced this pull request Jul 9, 2018
@asfgit asfgit closed this in 25e65c0 Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.