Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRILL-6612: Query fails with AssertionError when joining persistent a… #1385

Merged
merged 1 commit into from Jul 18, 2018

Conversation

@vvysotskyi
Copy link
Member

vvysotskyi commented Jul 18, 2018

…nd temporary tables

For details please see DRILL-6612

@@ -144,6 +144,11 @@ public static String getSchemaPath(List<String> schemaPath) {
return SCHEMA_PATH_JOINER.join(schemaPath);
}

/** Utility method to get the list with schema path components for given schema path string. */
public static List<String> getSchemaPathList(String schemaPath) {

This comment has been minimized.

Copy link
@arina-ielchiieva

arina-ielchiieva Jul 18, 2018

Member

Please rename to getSchemaPathAsList.

This comment has been minimized.

Copy link
@vvysotskyi

vvysotskyi Jul 18, 2018

Author Member

Thanks, done.

…nd temporary tables
@vvysotskyi vvysotskyi force-pushed the vvysotskyi:DRILL-6612 branch from bb9f670 to 65b06ea Jul 18, 2018
@arina-ielchiieva

This comment has been minimized.

Copy link
Member

arina-ielchiieva commented Jul 18, 2018

+1, LGTM.

@vvysotskyi

This comment has been minimized.

Copy link
Member Author

vvysotskyi commented Jul 18, 2018

@arina-ielchiieva, thanks for the review!

@arina-ielchiieva arina-ielchiieva merged commit 6bb0879 into apache:master Jul 18, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.