Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
DRILL-6644: Don't reserve space for incoming probe batches unnecessarily during the build phase. #1409
Previously the memory calculator for HashJoin was reserving space for the worst case sized incoming probe batch. This is actually completely unnecessary since we won't read probe side data before the build phase anymore after DRILL-6453, so this effectively causes memory to be underutilized.
There are two cases we have to handle:
The PR for DRILL-6453 must be merged first before this can go in. In this PR only look at the changes in the last commit.
@ilooner, this PR causes Advanced tests failures:
Could you please take a look?