Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
DRILL-4335: Apache Drill should support network encryption. #773
DRILL-4335: Apache Drill should support network encryption.
This pull request add's network encryption capability between Java Drill Client and Drillbit channel and also between Drillbit to Drillbit channel. It is extending SASL Authentication framework to support encryption.
Initial set of comments, with a few nits
I haven't reviewed the handlers yet
Two major concerns: this patch would increase heap memory consumption of idle connections, and there seem to be effects of one connection on another.
Other are mainly readability related.
NOTE: This pull request provides support for on-wire encryption using SASL framework. The communication channel that are covered are: 1) Between Drill JDBC client and Drillbit. 2) Between Drillbit to Drillbit i.e. control/data channels. 3) It has UI change to view encryption is enabled on which network channel and number of encrypted/unencrypted connections for user/control/data connections.