Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRILL-5775: Expand * into list of column/column family for MapR-DB b… #941

Closed
wants to merge 1 commit into from

Conversation

jinfengni
Copy link
Contributor

…inary table groupscan.

Move common code to HBaseUtils, so it's shared by both HBaseGroupScan and BinaryTableGroupScan
The issue was exposed by existing unit tests in contrib/format-maprdb; no new unit tests added.

…nary table groupscan.

 Move common code to HBaseUtils, so it's shared by both HBaseGroupScan and BinaryTableGroupScan
 The issue was exposed by existing unit tests in contrib/format-maprdb; no new unit tests added.
@paul-rogers
Copy link
Contributor

This fix is based on a change made in DRILL-5546. As described in DRILL-5830, the HBase part of that fix was a bit redundant. It turns out that HBase, via the project rel improvements in DRILL-5546, already expanded the wildcard into columns using the 'DrillHBaseTable.getRowType()' method. (You understand the details better than I...)

I wonder if we can do the same for MapR-DB binary? That way, we have just one common path for projection push down.

@paul-rogers
Copy link
Contributor

Is this PR obsolete after DRILL-5830 and the other DRILL-5775? If so can we close this one? Otherwise, if this one addresses a case not covered by the others, can we revise this PR to cover just that other case, on top of latest master? Thanks!

@prasadns14
Copy link
Contributor

Yes, this PR is now obsolete. All the cases are covered as part of DRILL-5830 and DRILL-5775

@ilooner
Copy link
Contributor

ilooner commented Jun 1, 2018

Since this PR is obsolete. I am closing it.

@ilooner ilooner closed this Jun 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants