From 3f5f5921e0ba798e07eadf61d26ceaf30a5bdccb Mon Sep 17 00:00:00 2001
From: zachjsh <zachjsh@gmail.com>
Date: Tue, 11 Jun 2024 18:08:35 -0400
Subject: [PATCH] Fix sql syntax error user (#16583)

This fixes an issue where in some cases, a SQL syntax error encountered when parsing / planning a query results in an error returned to the user with persona a `admin` when it should instead be `user`.
---
 .../druid/sql/calcite/planner/DruidPlanner.java      |  8 +-------
 .../druid/sql/calcite/CalciteInsertDmlTest.java      | 12 ++++++++++++
 2 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidPlanner.java b/sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidPlanner.java
index 4b697a0d5dfa..cf1d22eb39b4 100644
--- a/sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidPlanner.java
+++ b/sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidPlanner.java
@@ -380,13 +380,7 @@ public static DruidException translateException(Exception e)
         }
       }
 
-      return DruidException.forPersona(DruidException.Persona.DEVELOPER)
-                           .ofCategory(DruidException.Category.UNCATEGORIZED)
-                           .build(
-                               inner,
-                               "Unable to parse the SQL, unrecognized error from calcite: [%s]",
-                               inner.getMessage()
-                           );
+      return InvalidSqlInput.exception(inner.getMessage());
     }
     catch (RelOptPlanner.CannotPlanException inner) {
       return DruidException.forPersona(DruidException.Persona.USER)
diff --git a/sql/src/test/java/org/apache/druid/sql/calcite/CalciteInsertDmlTest.java b/sql/src/test/java/org/apache/druid/sql/calcite/CalciteInsertDmlTest.java
index bb9c03aa3c88..b40a4c87c3ab 100644
--- a/sql/src/test/java/org/apache/druid/sql/calcite/CalciteInsertDmlTest.java
+++ b/sql/src/test/java/org/apache/druid/sql/calcite/CalciteInsertDmlTest.java
@@ -1626,6 +1626,18 @@ public void testInsertWithInvalidSelectStatement()
         .verify();
   }
 
+  @Test
+  public void testInsertWithLongIdentifer()
+  {
+    // This test fails because an identifer is specified of length 200, which exceeds the length limit of 128
+    // characters.
+    String longIdentifer = new String(new char[200]).replace('\0', 'a');
+    testIngestionQuery()
+        .sql(StringUtils.format("INSERT INTO t SELECT %s FROM foo PARTITIONED BY ALL", longIdentifer)) // count is a keyword
+        .expectValidationError(invalidSqlContains(StringUtils.format("Length of identifier '%s' must be less than or equal to 128 characters", longIdentifer)))
+        .verify();
+  }
+
   @Test
   public void testInsertWithUnnamedColumnInSelectStatement()
   {