Fixes GCS based ingestion #12445
Merged
Fixes GCS based ingestion #12445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bucket name can contain underscores
|
Thanks for the fix, @tejaswini-imply .
|
| @@ -71,7 +71,7 @@ public CloudObjectLocation(@JsonProperty("bucket") String bucket, @JsonProperty( | |||
|
|
|||
| public CloudObjectLocation(URI uri) | |||
| { | |||
| this(uri.getHost(), uri.getPath()); | |||
| this(uri.getAuthority(), uri.getPath()); | |||
There was a problem hiding this comment.
should we fall back to getAuthority() only if getHost() returns null?
There was a problem hiding this comment.
Yeah, I would be more comfortable with that too.
There was a problem hiding this comment.
That would work as well.
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCP allows buckets in GCS to contain underscores in their names. When this location is mapped to
java.net.URI,URI#hostcomes out to be null asURIdoesn't allow it to contain underscores which is being translated to bucket name hence mappingURI#authorityto bucket name.Description
Fixed
CloudObjectLocationconstructor fromURIPreviously bucket variable of the
CloudObjectLocationis being set byuri.getHost()value (butjava.net.URIrefuses to handle underscore in host since it's not a valid character and gcs allows underscores in bucket naming)This modification allows
uri.getAuthority()to be mapped to bucket name which is allowing underscores to be present (Since all 3 S3, GCS, Azure Cloud buckets uris won't contain port or user information it is assumed that authority will return nothing more than the bucket name)Key changed/added classes in this PR
CloudObjectLocationThis PR has: