preserve explicitly specified dimension schema in "logical" schema of sampler response#14144
Merged
Conversation
… sampler response
cryptoe
approved these changes
Apr 23, 2023
clintropolis
added a commit
to clintropolis/druid
that referenced
this pull request
Apr 24, 2023
… sampler response (apache#14144)
clintropolis
deleted the
adjust-sampler-response-preserve-explicitly-specified-schemas-in-logical-schema
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adjusts the
logicalDimensionsof the sampler response to re-use any explicitly specified dimension schemas on the request instead of always mapping to the default for that logical type. This fixes a bug where if 'json' is explicitly specified we still return 'auto' on the response of the logical schema.This PR has: