Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add examples/ to CI UT/IT ignore #14306

Merged
merged 4 commits into from May 18, 2023

Conversation

abhishekrb19
Copy link
Contributor

Skip Java UTs and ITs when there are changes to examples folder which contain the quickstart tutorials. Also, sort the ignored paths.
This PR has:

  • been self-reviewed.

@abhishekrb19
Copy link
Contributor Author

I think GHA is running all the CI checks because of the change to workflow file. I can't think of a way to test this change besides verifying it later in a follow on test PR once this PR is merged to master. The test commit has now been reverted

@clintropolis clintropolis merged commit c546df3 into apache:master May 18, 2023
1 check passed
@abhishekagarwal87
Copy link
Contributor

abhishekagarwal87 commented May 18, 2023 via email

@clintropolis
Copy link
Member

This shouldn’t have been merged. ITs use files in examples directory which is why we don’t skip ITs when there are changes in examples folder.

I guess I assumed that any changes there with test implications would also have changes to java files, though if that's not true we can revert this

@abhishekrb19
Copy link
Contributor Author

@abhishekagarwal87 what part of the Java UTs and ITs rely on the example QuickStart stuff? Do we need some restructuring?

@abhishekagarwal87
Copy link
Contributor

@abhishekrb19 - you will find various examples if you search for examples in the integration-test module. The examples are not changed frequently so it's just best to not skip them altogether. can you revert this change?

@abhishekagarwal87 abhishekagarwal87 added this to the 27.0 milestone Jul 19, 2023
@abhishekrb19 abhishekrb19 deleted the skip_ut_it_examples branch August 22, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants