New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add examples/
to CI UT/IT ignore
#14306
Conversation
This reverts commit fc75eac.
I think GHA is running all the CI checks because of the change to workflow file. I can't think of a way to test this change besides verifying it later in a follow on test PR once this PR is merged to master. The test commit has now been reverted |
This shouldn’t have been merged. ITs use files in examples directory which
is why we don’t skip ITs when there are changes in examples folder.
…On Thu, 18 May 2023 at 6:16 AM, Clint Wylie ***@***.***> wrote:
Merged #14306 <#14306> into master.
—
Reply to this email directly, view it on GitHub
<#14306 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AALIWUIQPGAKXNLGAJYO4EDXGVWPHANCNFSM6AAAAAAYFTSL6Q>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
I guess I assumed that any changes there with test implications would also have changes to java files, though if that's not true we can revert this |
@abhishekagarwal87 what part of the Java UTs and ITs rely on the example QuickStart stuff? Do we need some restructuring? |
@abhishekrb19 - you will find various examples if you search for |
Skip Java UTs and ITs when there are changes to
examples
folder which contain the quickstart tutorials. Also, sort the ignored paths.This PR has: