Fix flaky HttpEmitterConfigTest and ParametrizedUriEmitterConfigTest.#14481
Merged
Conversation
Recently, we have seen flakiness in these two tests, apparently due to computations based on Runtime.getRuntime().maxMemory() differing during static initialization and in the actual tests. I can't think of a reason why this would be happening, but anyway, this patch switches the tests to use the statics instead of recomputing Runtime.getRuntime().maxMemory().
2 tasks
abhishekrb19
approved these changes
Jun 23, 2023
sergioferragut
pushed a commit
to sergioferragut/druid
that referenced
this pull request
Jul 21, 2023
…apache#14481) Recently, we have seen flakiness in these two tests, apparently due to computations based on Runtime.getRuntime().maxMemory() differing during static initialization and in the actual tests. I can't think of a reason why this would be happening, but anyway, this patch switches the tests to use the statics instead of recomputing Runtime.getRuntime().maxMemory().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently, we have seen flakiness in these two tests, apparently due to computations based on Runtime.getRuntime().maxMemory() differing during static initialization and in the actual tests. I can't think of a reason why this would be happening, but anyway, this patch switches the tests to use the statics instead of recomputing Runtime.getRuntime().maxMemory().