Filter on specific function names in INFORMATION_SCHEMA.ROUTINES tests#14482
Merged
zachjsh merged 1 commit intoJun 27, 2023
Merged
Conversation
abhishekrb19
force-pushed
the
info_schema_routines_test_update
branch
from
de311ba to
378471f
Compare
gianm
approved these changes
Jun 23, 2023
Contributor
Author
|
Seeing flaky test failures which will be fixed by #14481 🤞 |
sergioferragut
pushed a commit
to sergioferragut/druid
that referenced
this pull request
Jul 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testFilterAggregatorFunctionsOnInformationSchemaRoutinesandtestFilterScalarFunctionsOnInformationSchemaRoutinesnow validate on specific function names injected into the operator table from the standard list. So developers don't need to update the count when adding a new function.Ideally, we could inject a static set of operators into the operator table, but that seems a bit tricky to wire up, given the number of dependencies.
This PR has: