Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable parameters 'resultAsArray' working in materialized-view-selection with a group by query #8983

wants to merge 4 commits into
base: master


Copy link

sekingme commented Dec 3, 2019

Enable parameter 'resultAsArray' working in materialized-view-selection with a group by query.
Reference to the PR: GroupBy array-based result rows. (#8196)

PR (#8196) realize a new resultRow return in group by query and give a parameter choice for user to back to the old appropriate(array- or map-based rows). However, the parameter is not working in materialized-view-selection when user use query type 'view'.

In fact, the PR (#8196) totally ignored the situation of materialized-view. So, fix it.

The realization has been tested for 2 weeks in our cluster!

This PR has:

  • been self-reviewed.
  • using the concurrency checklist (Remove this item if the PR doesn't have any relation to concurrency.)
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths.
  • added integration tests.
  • been tested in a test Druid cluster.

Key changed/added classes in this PR
  • MaterializedViewQueryQueryToolChest
  • MaterializedViewQueryQueryToolChestTest
jiangshequan added 4 commits Nov 22, 2019

This comment has been minimized.

Copy link
Contributor Author

sekingme commented Dec 19, 2019

@jihoonson Hi, please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
1 participant
You can’t perform that action at this time.