Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit test #268

Merged
merged 2 commits into from Jan 23, 2019
Merged

unit test #268

merged 2 commits into from Jan 23, 2019

Conversation

sunbufu
Copy link
Contributor

@sunbufu sunbufu commented Jan 22, 2019

Hi, this PR commit 2 files for unit test.

  • CoderUtilTest
  • RegistryServerSyncTest

@codecov-io
Copy link

codecov-io commented Jan 22, 2019

Codecov Report

Merging #268 into develop will increase coverage by 0.4%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             develop     #268     +/-   ##
============================================
+ Coverage      21.58%   21.99%   +0.4%     
- Complexity       295      305     +10     
============================================
  Files             85       85             
  Lines           3456     3456             
  Branches         547      547             
============================================
+ Hits             746      760     +14     
+ Misses          2628     2613     -15     
- Partials          82       83      +1
Impacted Files Coverage Δ Complexity Δ
...apache/dubbo/admin/service/RegistryServerSync.java 94.02% <0%> (+4.47%) 24% <0%> (+4%) ⬆️
.../java/org/apache/dubbo/admin/common/util/Tool.java 26.31% <0%> (+10.52%) 2% <0%> (+1%) ⬆️
.../org/apache/dubbo/admin/common/util/CoderUtil.java 83.33% <0%> (+30%) 10% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a762a0f...989b222. Read the comment docs.

@nzomkxia nzomkxia merged commit 3adac8a into apache:develop Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants