feat: adaptive load balancer of adaptive service #2067

CoolIceV · 2022-10-02T04:23:40Z

What this PR does:
Provides an adaptive load balancer in unstable environments.
This is a component of adaptive service at the consumer side.

Which issue(s) this PR fixes:
Fixes #1834

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

All ut passed (run 'go test ./...' in project root)
After go-fmt ed , run 'go fmt project' using goland.
Golangci-lint passed, run 'sudo golangci-lint run' in project root.
Your new-created file needs to have apache license at the top, like other existed file does.
All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

CoolIceV · 2022-10-02T04:43:38Z

This load balancer takes into account the recent request success rate and request latency, the effect is as follows.

Flexible services are turned on at the marked line position. After that the QPS of different configured services is no longer the same, and the CPU load and latency of lower configured services are significantly reduced.

codecov-commenter · 2022-10-02T04:59:16Z

Codecov Report

Merging #2067 (11b348b) into 3.0 (19ddecf) will increase coverage by 0.05%.
The diff coverage is 93.10%.

❗ Current head 11b348b differs from pull request most recent head 98e894a. Consider uploading reports for the commit 98e894a to get more accurate results

@@            Coverage Diff             @@
##              3.0    #2067      +/-   ##
==========================================
+ Coverage   44.60%   44.66%   +0.05%     
==========================================
  Files         283      281       -2     
  Lines       17105    16841     -264     
==========================================
- Hits         7630     7522     -108     
+ Misses       8669     8532     -137     
+ Partials      806      787      -19

Impacted Files	Coverage Δ
cluster/loadbalance/p2c/loadbalance.go	`96.66% <93.10%> (+16.66%)`	⬆️
metadata/identifier/base_metadata_identifier.go	`86.48% <0.00%> (-7.64%)`	⬇️
...tocol/rest/server/server_impl/go_restful_server.go	`41.37% <0.00%> (-3.45%)`	⬇️
xds/utils/credentials/xds/handshake_info.go	`41.46% <0.00%> (ø)`
...y/event/service_instances_changed_listener_impl.go	`0.00% <0.00%> (ø)`
remoting/xds/client.go
remoting/xds/xds_client_factory.go
common/url.go	`59.50% <0.00%> (+0.45%)`	⬆️
config/logger_config.go	`63.33% <0.00%> (+0.62%)`	⬆️
registry/nacos/registry.go	`46.00% <0.00%> (+2.68%)`	⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

cluster/loadbalance/p2c/loadbalance.go

justxuewei · 2022-10-10T14:22:21Z

cluster/metrics/ema.go

+
+// EMA is a struct implemented Exponential Moving Average.
+// val = old * (1 - alpha) + new * alpha
+type EMA struct {


"EMA" and "SlidingWindowCounter" as metrics name might make others confused. Please give your approach a name, such as "hill climbing" (just an example), and move all of them to <Name>Metrics. If it will be extended to more approaches in the future, then they will be named <Name1>Metrics, <Name2>Metrics, etc.

To make it clearer, please keep EMA and SlidingWindowCounter in each file, create a new file, named <Name>_metrics.go, then merge EMAMetrics and SlidingWindowCounterMetrics into <Name>Metrics.

cluster/metrics/sliding_window_counter.go

justxuewei · 2022-10-10T14:37:20Z

cluster/metrics/sliding_window_counter.go

+	return c.size
+}
+
+func (c *SlidingWindowCounter) Add(_ int64) {


Can this parameter be deleted?

justxuewei · 2022-10-10T14:47:51Z

cluster/metrics/sliding_window_counter.go

+	c.count++
+}
+
+func (c *SlidingWindowCounter) Value() int64 {


Value is not a thread-safe method.

justxuewei

Is this PR for client? Will traffic limitation on the server side be submitted in another PR?

justxuewei · 2022-10-19T08:26:07Z

cluster/metrics/rolling/slidingwindowcounter_metrics.go

+ * limitations under the License.
+ */
+
+package rolling


Please rename this file to sliding_window_counter_metrics.go.

justxuewei · 2022-10-19T08:33:12Z

Lgtm, thanks.

CoolIceV · 2022-10-20T11:38:29Z

Is this PR for client? Will traffic limitation on the server side be submitted in another PR?

Yes.

sonarcloud · 2022-11-24T12:02:11Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

CoolIceV added 8 commits August 9, 2022 08:20

feat(adaptive service): add success rate and rtt to p2c's weight

71ec1b0

feat(adaptive service): p2c weight

0a129e1

Merge branch 'feat/adaptive-lb' into feat/adaptive-service

96904d5

feat(adaptive service): ema

2bca220

fix license

579612d

fix time

e48e3f5

fix error tests

164fa0f

fix p2c tests

47bd791

CoolIceV marked this pull request as ready for review October 2, 2022 04:52

justxuewei reviewed Oct 10, 2022

View reviewed changes

cluster/loadbalance/p2c/loadbalance.go Outdated Show resolved Hide resolved

justxuewei reviewed Oct 10, 2022

View reviewed changes

cluster/metrics/sliding_window_counter.go Outdated Show resolved Hide resolved

justxuewei reviewed Oct 10, 2022

View reviewed changes

CoolIceV added 8 commits October 11, 2022 08:29

remove useless division calculations

5e8eb9b

move ema and slidingWindowCounter to RollingMetrics

51a967d

make reading from ema and slidingWindowCounter thread-safe

3b6eba8

add GetMethodMetricsKey method

7995c81

validate rolling metrics implementation

3e3db96

add license

2f64f74

fix p2c tests

e88ccb9

add license

11b348b

justxuewei mentioned this pull request Oct 17, 2022

docs: update style and out-of-date links in readme #2079

Merged

5 tasks

justxuewei reviewed Oct 19, 2022

View reviewed changes

justxuewei approved these changes Oct 19, 2022

View reviewed changes

rename sliding_window_counter_metrics

98e894a

Lvnszn approved these changes Nov 4, 2022

View reviewed changes

CoolIceV mentioned this pull request Nov 9, 2022

feat: auto concurrency limiter of adaptive service #2114

Merged

5 tasks

CoolIceV changed the base branch from 3.0 to 3.0-adaptive-stream November 24, 2022 11:55

remove useless factor

be43c0a

AlexStocks approved these changes Dec 10, 2022

View reviewed changes

AlexStocks merged commit 4ed7c71 into apache:3.0-adaptive-stream Dec 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: adaptive load balancer of adaptive service #2067

feat: adaptive load balancer of adaptive service #2067

CoolIceV commented Oct 2, 2022

CoolIceV commented Oct 2, 2022 •

edited

codecov-commenter commented Oct 2, 2022 •

edited

justxuewei Oct 10, 2022 •

edited

justxuewei Oct 10, 2022 •

edited

justxuewei Oct 10, 2022

justxuewei Oct 10, 2022

justxuewei left a comment

justxuewei Oct 19, 2022

justxuewei commented Oct 19, 2022

CoolIceV commented Oct 20, 2022

sonarcloud bot commented Nov 24, 2022

feat: adaptive load balancer of adaptive service #2067

feat: adaptive load balancer of adaptive service #2067

Conversation

CoolIceV commented Oct 2, 2022

CoolIceV commented Oct 2, 2022 • edited

codecov-commenter commented Oct 2, 2022 • edited

Codecov Report

justxuewei Oct 10, 2022 • edited

Choose a reason for hiding this comment

justxuewei Oct 10, 2022 • edited

Choose a reason for hiding this comment

justxuewei Oct 10, 2022

Choose a reason for hiding this comment

justxuewei Oct 10, 2022

Choose a reason for hiding this comment

justxuewei left a comment

Choose a reason for hiding this comment

justxuewei Oct 19, 2022

Choose a reason for hiding this comment

justxuewei commented Oct 19, 2022

CoolIceV commented Oct 20, 2022

sonarcloud bot commented Nov 24, 2022

CoolIceV commented Oct 2, 2022 •

edited

codecov-commenter commented Oct 2, 2022 •

edited

justxuewei Oct 10, 2022 •

edited

justxuewei Oct 10, 2022 •

edited