New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.0 notify sleep #2139
3.0 notify sleep #2139
Conversation
e06207f
to
d098bd6
Compare
Codecov Report
@@ Coverage Diff @@
## 3.0 #2139 +/- ##
==========================================
- Coverage 44.26% 44.21% -0.06%
==========================================
Files 283 283
Lines 17050 17076 +26
==========================================
+ Hits 7548 7550 +2
- Misses 8707 8731 +24
Partials 795 795
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
d098bd6
to
6ca5d9c
Compare
6ca5d9c
to
b5a33a9
Compare
|
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @binbin0325, lgtm!
|
I found that there is a ci failed, and I triggered it to rerun. |








What this PR does:
修复consumer启动时立即发起调用,出现找不到provider的相关问题。本质原因是因为在consumer启动时会“异步”订阅provider,在发起调用时有可能订阅回调事件还没有被触发,从而导致找不到provider.
修改:在异步订阅前 先同步获取provider实例。(当前pr修改了nacos和polaris,后续可以按需实现zk,etcd.)
Which issue(s) this PR fixes:
Fixes #1991
You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed