registry type support all #2140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyunxing92
approved these changes
Dec 2, 2022
Codecov Report
@@ Coverage Diff @@
## 3.0 #2140 +/- ##
==========================================
+ Coverage 44.33% 44.39% +0.05%
==========================================
Files 283 283
Lines 17082 17082
==========================================
+ Hits 7574 7584 +10
+ Misses 8715 8703 -12
- Partials 793 795 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
binbin0325
approved these changes
Dec 2, 2022
config/registry_config.go
Outdated
| return urls, nil | ||
| } | ||
|
|
||
| if c.RegistryType == constant.RegistryTypeService { |
AlexStocks
approved these changes
Dec 3, 2022
|
看了下 samples ci 错误，依赖的 gost 1.13.2 nacos v1 所以失败了 |
|
Kudos, SonarCloud Quality Gate passed!
|
Lvnszn
pushed a commit
to Lvnszn/dubbo-go
that referenced
this pull request
Jan 15, 2023
* registry type support all * fix test * set default to interface * use default protocol registry * fix unit test * use swith to judge * add registry support all test * Resolve registry name conflicts * fix ut err Co-authored-by: bobtthp <bobtthp@bob-Mac-mini.local> Co-authored-by: bob <bob@bobdeMacBook-Pro.local> Co-authored-by: bobtthp <bobtthp@bob1.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
#2095
Which issue(s) this PR fixes:
Fixes #
You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed