Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update changelog for release v3.0.4 #2147

Merged
merged 6 commits into from Dec 2, 2022

Conversation

justxuewei
Copy link
Member

What this PR does:

Updated changelog for release v3.0.4. Fixed some typos in the changelog.

Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

Signed-off-by: Xuewei Niu <justxuewei@apache.org>
Signed-off-by: Xuewei Niu <justxuewei@apache.org>
Signed-off-by: Xuewei Niu <justxuewei@apache.org>
Signed-off-by: Xuewei Niu <justxuewei@apache.org>
Signed-off-by: Xuewei Niu <justxuewei@apache.org>
@justxuewei
Copy link
Member Author

justxuewei commented Dec 2, 2022

I closed #2141 and reopened this pull request that the target branch is 3.0. I still found that SonarCloud failed because of duplication as previously. It should be ignored. Please @binbin0325 @zhaoyunxing92 @AlexStocks take a look.

@codecov-commenter
Copy link

Codecov Report

Merging #2147 (6001f0f) into 3.0 (9e4452a) will decrease coverage by 0.87%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              3.0    #2147      +/-   ##
==========================================
- Coverage   45.21%   44.34%   -0.88%     
==========================================
  Files         283      283              
  Lines       17572    17050     -522     
==========================================
- Hits         7946     7561     -385     
+ Misses       8795     8692     -103     
+ Partials      831      797      -34     
Impacted Files Coverage Δ
protocol/dubbo3/dubbo3_invoker.go 53.27% <0.00%> (-9.64%) ⬇️
remoting/getty/getty_server.go 46.49% <0.00%> (-9.28%) ⬇️
metadata/report/delegate/delegate_report.go 35.09% <0.00%> (-7.29%) ⬇️
remoting/getty/getty_client.go 43.60% <0.00%> (-7.22%) ⬇️
config/service_config.go 53.04% <0.00%> (-5.21%) ⬇️
protocol/grpc/client.go 63.01% <0.00%> (-4.73%) ⬇️
remoting/getty/pool.go 42.47% <0.00%> (-4.54%) ⬇️
...tocol/rest/server/server_impl/go_restful_server.go 41.37% <0.00%> (-3.45%) ⬇️
protocol/grpc/server.go 67.81% <0.00%> (-3.22%) ⬇️
config/reference_config.go 26.35% <0.00%> (-3.20%) ⬇️
... and 9 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Dec 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
4.0% 4.0% Duplication

@AlexStocks AlexStocks merged commit 2e4e958 into apache:3.0 Dec 2, 2022
@justxuewei justxuewei added this to the v3.0.4 milestone Dec 4, 2022
binbin0325 pushed a commit to binbin0325/dubbo-go that referenced this pull request Dec 10, 2022
* docs: update changelog for release v3.0.4

Signed-off-by: Xuewei Niu <justxuewei@apache.org>

* docs: remove nacos upgrade from release v3.0.4

Signed-off-by: Xuewei Niu <justxuewei@apache.org>

* docs: update readme and changelog

Signed-off-by: Xuewei Niu <justxuewei@apache.org>

* docs: update readme_cn

Signed-off-by: Xuewei Niu <justxuewei@apache.org>

* chore: update dubbo-go version

Signed-off-by: Xuewei Niu <justxuewei@apache.org>

* Trigger update

Signed-off-by: Xuewei Niu <justxuewei@apache.org>
Co-authored-by: Albumen Kevin <jhq0812@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants