Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Prometheus Pushgateway can not enable #2594

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FoghostCn
Copy link
Contributor

Fix Prometheus Pushgateway can not enable

Copy link

sonarcloud bot commented Feb 4, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
1.8% Duplication on New Code

See analysis details on SonarCloud

@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (198504b) 47.55% compared to head (bea4dd5) 47.62%.

❗ Current head bea4dd5 differs from pull request most recent head 90da8be. Consider uploading reports for the commit 90da8be to get more accurate results

Files Patch % Lines
metrics/options.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2594      +/-   ##
==========================================
+ Coverage   47.55%   47.62%   +0.06%     
==========================================
  Files         318      318              
  Lines       23627    23631       +4     
==========================================
+ Hits        11236    11254      +18     
+ Misses      11328    11314      -14     
  Partials     1063     1063              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justxuewei
Copy link
Member

Could you backport this patch to release-3.1?

@justxuewei
Copy link
Member

justxuewei commented Feb 14, 2024

Btw, what action will be taken once dev-3.3 branch is ready?

  1. Rebase atop of main branch, and then rename it to main.
  2. Rename it to main.

If 2 will be taken, then a forward port to the branch is needed as well. /cc @chickenlj

Copy link
Member

@justxuewei justxuewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Block temporarily.

@FoghostCn
Copy link
Contributor Author

Could you backport this patch to release-3.1?

release-3.1 has no options support,so this pr no need to backport to release-3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants