Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ftr: add nacos registry #82

Closed
wants to merge 2 commits into from
Closed

Ftr: add nacos registry #82

wants to merge 2 commits into from

Conversation

onewe
Copy link
Contributor

@onewe onewe commented Dec 3, 2022

  • register service to nacos

@onewe onewe requested review from CherishCai and removed request for yang20150702 December 9, 2022 14:32
CherishCai
CherishCai approved these changes Dec 9, 2022
View reviewed changes
Copy link

@CherishCai CherishCai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yang20150702 yang20150702 self-requested a review December 10, 2022 00:42
@onewe onewe force-pushed the service_discovery branch 2 times, most recently from 0049fd1 to 3ed2a7b Compare December 11, 2022 12:24
@chickenlj
Copy link
Contributor

Please fix the failed tests.

@onewe
Copy link
Contributor Author

onewe commented Jan 3, 2023

I will fix it

@chickenlj chickenlj mentioned this pull request Jan 5, 2023
Open
@onewe onewe closed this Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CherishCai CherishCai CherishCai approved these changes

@yang20150702 yang20150702 Awaiting requested review from yang20150702

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@onewe @chickenlj @CherishCai