From 6c814d2f850ce991b89292ebc5f8adc4e33da48b Mon Sep 17 00:00:00 2001 From: plusmancn Date: Fri, 17 Sep 2021 14:00:24 +0800 Subject: [PATCH] fix: prevent the test being ignored --- dubbo-samples-migration/README.md | 12 ++++++++---- .../case-versions.conf | 2 +- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/dubbo-samples-migration/README.md b/dubbo-samples-migration/README.md index ed95960eb1..7feebb4eb9 100644 --- a/dubbo-samples-migration/README.md +++ b/dubbo-samples-migration/README.md @@ -15,20 +15,24 @@ dubbo.consumer.version=2.7.* ``` And then in each consumer and provider project, you can configure `POM`'s properties as follows: ```xml -# consumer side + 2.7.13 -# provider side + 2.7.13 ``` -When the Integration Tests trigger, these properties will be overwritten by maven, for example: +If we have the env of `DUBBO_VERSION=3.0.3-SNAPSHOT,2.7.13`, when the Integration Tests trigger, these properties will be overwritten by maven, for example: ```shell mvn -Ddubbo.provider.version=3.0.3-SNAPSHOT -Ddubbo.consumer.version=2.7.13 -Dspring.version=4.3.16.RELEASE ``` - +But in the dubbo-samples's Dubbo 3 CI env, there only has `DUBBO_VERSION=3.0.3-SNAPSHOT`, we have to specify one side's version to prevent the test being ignored, for example: +```yaml +dubbo.provider.version=3.* +dubbo.consumer.version=2.7.13 # <= specific version +``` \ No newline at end of file diff --git a/dubbo-samples-migration/dubbo-samples-migration-case-default/case-versions.conf b/dubbo-samples-migration/dubbo-samples-migration-case-default/case-versions.conf index 3e63442a8f..b5a235b032 100644 --- a/dubbo-samples-migration/dubbo-samples-migration-case-default/case-versions.conf +++ b/dubbo-samples-migration/dubbo-samples-migration-case-default/case-versions.conf @@ -23,4 +23,4 @@ spring.version=4.*, 5.* # Support Compatibility test dubbo.provider.version=3.* -dubbo.consumer.version=2.7.* +dubbo.consumer.version=2.7.13