New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for deprecated o.a.d.c.extension.Activate#before and #after #2180
Comments
+1 |
ok. I'll send a mail for this. |
+1 |
I'll send a PR to deprecate these two methods. |
@diecui1202 #1926 is confusing, since I tried the before,after in our project, found it works. Consider a scene: a user's custorm filter which need to after or before a given filter, as the other filter's order are uncertain, the relative order maybe more more suitable. |
I've checked the whole source code, these two methods haven't be used. Instead, #order is used more frequent.
More important, use these two properties for sorting is not correct. There has a issue and PR about it. See #1926 and #639
So, I suggest deprecating these two method on annotation Activate.
The text was updated successfully, but these errors were encountered: