Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for deprecated o.a.d.c.extension.Activate#before and #after #2180

Closed
diecui1202 opened this issue Aug 3, 2018 · 5 comments
Closed

Comments

@diecui1202
Copy link

diecui1202 commented Aug 3, 2018

I've checked the whole source code, these two methods haven't be used. Instead, #order is used more frequent.

More important, use these two properties for sorting is not correct. There has a issue and PR about it. See #1926 and #639

So, I suggest deprecating these two method on annotation Activate.

@kimmking
Copy link
Member

kimmking commented Aug 3, 2018

+1
and I think vote should be via email?

@diecui1202
Copy link
Author

ok. I'll send a mail for this.

@carryxyh
Copy link
Member

carryxyh commented Aug 6, 2018

+1
As far as I know, very few people use them.And this is a more edge feature

@diecui1202
Copy link
Author

I'll send a PR to deprecate these two methods.

diecui1202 added a commit to diecui1202/incubator-dubbo that referenced this issue Aug 7, 2018
@cdfive
Copy link

cdfive commented Dec 9, 2018

@diecui1202
Hi, I found the ActivateComparator class use these two methods, and there is also a test case:
https://github.com/apache/incubator-dubbo/blob/master/dubbo-common/src/test/java/org/apache/dubbo/common/extension/support/ActivateComparatorTest.java
The test case use before and after method in filter's @activate, and the case is passed.

#1926 is confusing, since I tried the before,after in our project, found it works.

Consider a scene: a user's custorm filter which need to after or before a given filter, as the other filter's order are uncertain, the relative order maybe more more suitable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants