Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance logger adapter to use a configured logger #10952

Merged
merged 4 commits into from Nov 26, 2022

Conversation

AlbumenJ
Copy link
Member

What is the purpose of the change

WIP: Docs

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Merging #10952 (d2e7e99) into 3.2 (a931777) will decrease coverage by 0.03%.
The diff coverage is 37.50%.

@@             Coverage Diff              @@
##                3.2   #10952      +/-   ##
============================================
- Coverage     20.67%   20.64%   -0.04%     
  Complexity       14       14              
============================================
  Files          1441     1444       +3     
  Lines         59690    59950     +260     
  Branches       8758     8784      +26     
============================================
+ Hits          12341    12375      +34     
- Misses        45269    45486     +217     
- Partials       2080     2089       +9     
Impacted Files Coverage Δ
...g/apache/dubbo/common/json/impl/FastJson2Impl.java 37.50% <0.00%> (ø)
.../org/apache/dubbo/common/logger/LoggerAdapter.java 0.00% <0.00%> (ø)
...ache/dubbo/common/logger/jcl/JclLoggerAdapter.java 0.00% <ø> (ø)
...ache/dubbo/common/logger/jdk/JdkLoggerAdapter.java 0.00% <0.00%> (ø)
...ubbo/common/logger/log4j2/Log4j2LoggerAdapter.java 0.00% <0.00%> (ø)
.../org/apache/dubbo/common/logger/LoggerFactory.java 23.25% <39.39%> (+2.66%) ⬆️
.../dubbo/common/logger/log4j/Log4jLoggerAdapter.java 28.78% <50.00%> (+8.37%) ⬆️
.../dubbo/common/logger/slf4j/Slf4jLoggerAdapter.java 38.46% <50.00%> (+38.46%) ⬆️
...ain/java/org/apache/dubbo/rpc/cluster/Cluster.java 50.00% <0.00%> (-25.00%) ⬇️
...apache/dubbo/rpc/protocol/injvm/InjvmProtocol.java 34.37% <0.00%> (-5.63%) ⬇️
... and 37 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chickenlj
Copy link
Contributor

This has been an issue for a while, sometimes the framework picks the wrong logger implementation and directs all logging messages there, as a result, the users cannot see any logs in the expected place.

@sonarcloud
Copy link

sonarcloud bot commented Nov 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit 247eeb3 into apache:3.2 Nov 26, 2022
This was referenced Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants