Fix tri convert upper header #11075
Merged
Fix tri convert upper header #11075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guohao
reviewed
Dec 5, 2022
| String key = lruHeaderMap.get(entry.getKey()); | ||
| if (key == null) { | ||
| final String lowerCaseKey = entry.getKey().toLowerCase(Locale.ROOT); | ||
| lruHeaderMap.put(entry.getKey(), lowerCaseKey); |
There was a problem hiding this comment.
The concurrency problem here is ignored and does not affect the final result
There was a problem hiding this comment.
A unit test may need to verify
...rpc/dubbo-rpc-triple/src/main/java/org/apache/dubbo/rpc/protocol/tri/stream/StreamUtils.java
Show resolved
Hide resolved
|
|
||
| private static final int MAX_LRU_HEADER_MAP_SIZE = 1024; | ||
|
|
||
| private static final Map<String, String> lruHeaderMap = new LinkedHashMap<String, String>(MAX_LRU_HEADER_MAP_SIZE, 1f, true) { |
Codecov Report
@@ Coverage Diff @@
## 3.1 #11075 +/- ##
============================================
- Coverage 69.29% 64.61% -4.68%
+ Complexity 124 14 -110
============================================
Files 1471 1421 -50
Lines 77362 59330 -18032
Branches 13577 8720 -4857
============================================
- Hits 53606 38335 -15271
+ Misses 19067 16940 -2127
+ Partials 4689 4055 -634
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Brief changelog
Verifying this change
Checklist