Add Spring Security Plugin #11418
Merged
Add Spring Security Plugin #11418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dubbo-dependencies-bom/pom.xml
AlbumenJ
requested changes
Feb 4, 2023
|
|
||
| package org.apache.dubbo.config; | ||
|
|
||
| public class SecureConfig extends AbstractConfig{ |
There was a problem hiding this comment.
What is the purpose of defining this class?
There was a problem hiding this comment.
到时考虑到一些安全的配置，现阶段暂时不需要，已经移出
Comment on lines
44
to
47
| public static List<FilterConditionMatcher> conditionMatchers = new ArrayList<>(); | ||
|
|
||
| static{ | ||
| conditionMatchers.add(new FilterConditionMatcherOnClass(SECURITY_CONTEXT_HOLDER_CLASS_NAME){ |
There was a problem hiding this comment.
Prevent use static in Dubbo for multi instance status purpose.
There was a problem hiding this comment.
检查在加载时就已经决定了，没有必要实例化过程中检查
Codecov Report
@@ Coverage Diff @@
## 3.2 #11418 +/- ##
============================================
- Coverage 64.88% 64.80% -0.08%
Complexity 14 14
============================================
Files 1506 1511 +5
Lines 62752 62834 +82
Branches 9164 9169 +5
============================================
+ Hits 40715 40720 +5
- Misses 17798 17878 +80
+ Partials 4239 4236 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AlbumenJ
requested changes
Feb 7, 2023
Comment on lines
26
to
32
| private static final ObjectMapper mapper = new ObjectMapper(); | ||
|
|
||
| static{ | ||
| mapper.registerModule(new CoreJackson2Module()); | ||
| } | ||
|
|
||
| private ObjectMapperCodec(){} |
There was a problem hiding this comment.
Suggested change
| private static final ObjectMapper mapper = new ObjectMapper(); | |
| static{ | |
| mapper.registerModule(new CoreJackson2Module()); | |
| } | |
| private ObjectMapperCodec(){} | |
| private final ObjectMapper mapper = new ObjectMapper(); | |
| public ObjectMapperCodec(){ | |
| mapper.registerModule(new CoreJackson2Module()); | |
| } |
This reverts commit 07d6ffe.
…urity # Conflicts: # dubbo-plugin/dubbo-spring-security/src/main/java/org/apache/dubbo/spring/security/utils/ObjectMapperCodec.java
|
Kudos, SonarCloud Quality Gate passed! |
AlbumenJ
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Spring Security Plugin