Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-5479] refactor generic invoke support #5481

Open
wants to merge 1 commit into
base: master
from

Conversation

@hengyunabc
Copy link
Contributor

hengyunabc commented Dec 13, 2019

What is the purpose of the change

refactor generic invoke support

Brief changelog

  • A better way to collect interfaces in AbstractProxyFactory#getProxy
  • fix #5479

Verifying this change

/**
* AbstractProxyFactory
*/
public abstract class AbstractProxyFactory implements ProxyFactory {
private static final Class<?>[] INTERNAL_INTERFACES = new Class<?>[]{
EchoService.class, Destroyable.class

This comment has been minimized.

Copy link
@chickenlj

chickenlj Dec 17, 2019

Contributor

this part is lost in the pr.

interfaces.add(EchoService.class);
if (generic) {
if (!GenericService.class.isAssignableFrom(invoker.getInterface())) {
interfaces.add(GenericService.class);

This comment has been minimized.

Copy link
@chickenlj

chickenlj Dec 17, 2019

Contributor

com.alibaba.dubbo.rpc.service.GenericService should still b supported.

@chickenlj

This comment has been minimized.

Copy link
Contributor

chickenlj commented Dec 17, 2019

Please check the comments I left on your PR. I would suggest that you submit a new PR and start work from the latest code in the master branch so as to make sure changes are limited to this specific issue #5479.

@hengyunabc hengyunabc force-pushed the hengyunabc:fix_generic branch from 0c02529 to fecc62e Dec 19, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 19, 2019

Codecov Report

Merging #5481 into master will increase coverage by 0.01%.
The diff coverage is 57.89%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #5481      +/-   ##
============================================
+ Coverage     61.18%   61.19%   +0.01%     
- Complexity      421      422       +1     
============================================
  Files           922      922              
  Lines         37507    37518      +11     
  Branches       5440     5442       +2     
============================================
+ Hits          22947    22959      +12     
+ Misses        12072    12064       -8     
- Partials       2488     2495       +7
Impacted Files Coverage Δ Complexity Δ
...pache/dubbo/config/utils/ReferenceConfigCache.java 63.33% <100%> (ø) 0 <0> (ø) ⬇️
.../java/org/apache/dubbo/config/ReferenceConfig.java 69.58% <100%> (ø) 0 <0> (ø) ⬇️
...org/apache/dubbo/rpc/filter/GenericImplFilter.java 54.45% <25%> (-3%) 0 <0> (ø)
...g/apache/dubbo/rpc/proxy/AbstractProxyFactory.java 78.94% <77.77%> (+12.28%) 0 <0> (ø) ⬇️
.../remoting/transport/netty4/NettyServerHandler.java 56.81% <0%> (-11.37%) 0% <0%> (ø)
...va/org/apache/dubbo/remoting/TimeoutException.java 22.22% <0%> (-11.12%) 0% <0%> (ø)
...dubbo/remoting/exchange/support/DefaultFuture.java 78.37% <0%> (-4.51%) 0% <0%> (ø)
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0%> (-4.35%) 0% <0%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 66.33% <0%> (-1%) 0% <0%> (ø)
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 79.16% <0%> (ø) 0% <0%> (ø) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e4b2f3...a04de2a. Read the comment docs.

@hengyunabc hengyunabc force-pushed the hengyunabc:fix_generic branch from fecc62e to a04de2a Dec 19, 2019
@htynkn htynkn changed the title refactor generic invoke support, fix #5479 [Dubbo-5479] refactor generic invoke support Dec 20, 2019
@htynkn htynkn added the type/bug label Dec 20, 2019
@chickenlj chickenlj added this to the 2.7.6 milestone Dec 30, 2019
@chickenlj chickenlj self-assigned this Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.