Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-6720] fix bug same interface unexport and export fail. also support hotload service #6720

Merged
merged 14 commits into from Jun 15, 2021

Conversation

@owen200008
Copy link

@owen200008 owen200008 commented Sep 10, 2020

What is the purpose of the change

fix bug same interface unexport and export fail.
delegate exportmap and support hotload export

Brief changelog

  1. use interface to oper exportmap
  2. remove export must make sure the same export

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.
@owen200008 owen200008 changed the title Fix hotload service [Dubbo-2.7.8] Fix hotload service Sep 10, 2020
@owen200008 owen200008 changed the title [Dubbo-2.7.8] Fix hotload service [Dubbo-2.7.8] support hotload service Sep 10, 2020
@owen200008 owen200008 changed the title [Dubbo-2.7.8] support hotload service [Dubbo-6720] support hotload service Sep 10, 2020
@owen200008 owen200008 changed the title [Dubbo-6720] support hotload service [Dubbo-6720] fix bug same interface unexport and export fail. also support hotload service Sep 16, 2020
@AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Apr 12, 2021

@owen200008 Hi, thanks for your contribution.

Please merge the latest master branch to resolve confilcts.

@owen200008
Copy link
Author

@owen200008 owen200008 commented Apr 13, 2021

@AlbumenJ I have resolve confilcts
please check the result.

@AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Apr 14, 2021

image

Please fix codestyle check.

@owen200008 owen200008 force-pushed the fix_hotload_service branch from f246906 to 396a94a Apr 14, 2021
@owen200008
Copy link
Author

@owen200008 owen200008 commented Apr 14, 2021

@AlbumenJ finish thanks!

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jun 11, 2021

Codecov Report

Merging #6720 (31a3892) into master (149d1f6) will increase coverage by 0.09%.
The diff coverage is 84.61%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6720      +/-   ##
============================================
+ Coverage     60.99%   61.09%   +0.09%     
  Complexity      490      490              
============================================
  Files          1090     1091       +1     
  Lines         43951    43980      +29     
  Branches       6423     6429       +6     
============================================
+ Hits          26810    26871      +61     
+ Misses        14156    14124      -32     
  Partials       2985     2985              
Impacted Files Coverage Δ
...apache/dubbo/rpc/protocol/injvm/InjvmProtocol.java 74.35% <71.42%> (+2.13%) ⬆️
...rg/apache/dubbo/rpc/protocol/AbstractProtocol.java 75.00% <75.00%> (+2.27%) ⬆️
...ache/dubbo/rpc/protocol/AbstractProxyProtocol.java 60.71% <100.00%> (ø)
...apache/dubbo/rpc/protocol/DelegateExporterMap.java 100.00% <100.00%> (ø)
...apache/dubbo/rpc/protocol/dubbo/DubboExporter.java 100.00% <100.00%> (ø)
...apache/dubbo/rpc/protocol/dubbo/DubboProtocol.java 63.85% <100.00%> (-0.13%) ⬇️
...apache/dubbo/rpc/protocol/injvm/InjvmExporter.java 100.00% <100.00%> (ø)
.../apache/dubbo/rpc/protocol/injvm/InjvmInvoker.java 81.81% <100.00%> (ø)
...g/apache/dubbo/remoting/p2p/support/FileGroup.java 50.94% <0.00%> (-13.21%) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-5.67%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 149d1f6...31a3892. Read the comment docs.

@AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Jun 15, 2021

Great! @owen200008 Would you please pick these changes to 3.0?

@AlbumenJ AlbumenJ merged commit 222bf15 into apache:master Jun 15, 2021
10 checks passed
@owen200008 owen200008 deleted the fix_hotload_service branch Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants