Skip to content

[DUBBO-63] an object MUST equals to itself.#7212

Merged
chickenlj merged 1 commit intoapache:masterfrom
xenoamess-fork:an_object_MUST_equals_itself
Feb 24, 2021
Merged

[DUBBO-63] an object MUST equals to itself.#7212
chickenlj merged 1 commit intoapache:masterfrom
xenoamess-fork:an_object_MUST_equals_itself

Conversation

@XenoAmess
Copy link

What is the purpose of the change

an object MUST equals to itself.

@XenoAmess XenoAmess changed the title an object MUST equals to itself. [DUBBO-63] an object MUST equals to itself. Feb 19, 2021
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@XenoAmess
Copy link
Author

XenoAmess commented Feb 23, 2021

@chickenlj this pr can be seen as a bug.
I havn't see people making classes who can have object who can not equals itself.
so I suggest reopen.

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chickenlj
Copy link
Contributor

I am merging this patch now.

@chickenlj chickenlj added this to the 2.7.10 milestone Feb 24, 2021
@chickenlj chickenlj merged commit 15fc5b4 into apache:master Feb 24, 2021
AlbumenJ added a commit to AlbumenJ/dubbo that referenced this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments