Skip to content

Conversation

@XenoAmess
Copy link

@XenoAmess XenoAmess commented Apr 14, 2021

What is the purpose of the change

add checkstyles to make sure there be no crlf file.

if the build fails, then the checkstyles works.

simple and easy.

...I can find some time to fix all these checkstyles for you but I want to know about your opinions first.

Brief changelog

Verifying this change

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@XenoAmess XenoAmess force-pushed the add_some_rules_to_checkstyles branch from 24ed16e to 7b554dd Compare April 14, 2021 18:35
@AlbumenJ
Copy link
Member

@XenoAmess For lineSeparator I think we should discuss in mailing list(dev@dubbo.apache.org) first.

Also, for now, you can reopen the previous PRs about code style. I am sorry for keeping you waiting so long.

@chickenlj
Copy link
Contributor

Let's do this on the 3.0 branch.

@chickenlj
Copy link
Contributor

Thank you @XenoAmess , please see this patch #8019 Albumen added to 3.0.

@chickenlj chickenlj closed this Jun 10, 2021
@XenoAmess
Copy link
Author

XenoAmess commented Jun 14, 2021

Thank you @XenoAmess , please see this patch #8019 Albumen added to 3.0.

@chickenlj
got it.
looks good.
thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants