Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate the filter returned by the getActivateExtension method #7600

Merged
merged 6 commits into from Jun 8, 2021

Conversation

@xiaoheng1
Copy link
Contributor

@xiaoheng1 xiaoheng1 commented Apr 22, 2021

What is the purpose of the change

De-duplicate the filter returned by the getActivateExtension method

see more detail from fix #7587

Brief changelog

Verifying this change

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Apr 22, 2021

Codecov Report

Merging #7600 (ff41121) into master (c8d176f) will increase coverage by 0.37%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7600      +/-   ##
============================================
+ Coverage     60.47%   60.85%   +0.37%     
- Complexity      456      491      +35     
============================================
  Files          1090     1090              
  Lines         43937    43952      +15     
  Branches       6420     6423       +3     
============================================
+ Hits          26571    26747     +176     
+ Misses        14402    14230     -172     
- Partials       2964     2975      +11     
Impacted Files Coverage Δ
...apache/dubbo/common/extension/ExtensionLoader.java 80.81% <80.00%> (-0.47%) ⬇️
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) ⬇️
...port/identifier/BaseServiceMetadataIdentifier.java 53.57% <0.00%> (-7.15%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0.00%> (-1.91%) ⬇️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 72.61% <0.00%> (-1.20%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 75.92% <0.00%> (-0.75%) ⬇️
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 54.41% <0.00%> (-0.16%) ⬇️
...n/java/org/apache/dubbo/common/utils/NetUtils.java 69.30% <0.00%> (+0.33%) ⬆️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 79.72% <0.00%> (+0.34%) ⬆️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8d176f...ff41121. Read the comment docs.

# Conflicts:
#	dubbo-common/src/test/java/org/apache/dubbo/common/extension/ExtensionLoaderTest.java
@AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented May 23, 2021

Shall we notify users that there contains two extension have the same name by loggeer?

@xiaoheng1
Copy link
Contributor Author

@xiaoheng1 xiaoheng1 commented May 23, 2021

Shall we notify users that there contains two extension have the same name by loggeer?

If just print the log, the user also needs to remove it manually, and may also ignore this log.
If the system supports filtering, it will be easier for users to use.

@AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented May 23, 2021

Shall we notify users that there contains two extension have the same name by loggeer?

If just print the log, the user also needs to remove it manually, and may also ignore this log.
If the system supports filtering, it will be easier for users to use.

Filter those duplicated and log out to notify that has been filtered.

@xiaoheng1
Copy link
Contributor Author

@xiaoheng1 xiaoheng1 commented May 23, 2021

Filter those duplicated and log out to notify that has been filtered.

Sorry, I misunderstand. Now let’s add a log.

xiaoheng1 added 4 commits May 23, 2021
# Conflicts:
#	dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java
@AlbumenJ AlbumenJ merged commit 275ac51 into apache:master Jun 8, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants