Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annotation cannt be serializable,so change to String #7908

Merged
merged 4 commits into from Jun 24, 2021

Conversation

@jingxiang
Copy link
Contributor

@jingxiang jingxiang commented May 28, 2021

What is the purpose of the change

#7907

Brief changelog

修改MethodDefinition、ServiceDefinition中annotation序列化存储类型为String的字符串(FastJson在序列化List的时候存储的元数据就是[],所以这里直接修改数据类型为List )

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.
@AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented May 31, 2021

Please fix ut

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jun 22, 2021

Codecov Report

Merging #7908 (ea475ce) into master (f26ba91) will increase coverage by 0.06%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7908      +/-   ##
============================================
+ Coverage     60.30%   60.36%   +0.06%     
+ Complexity      546      487      -59     
============================================
  Files          1089     1090       +1     
  Lines         43852    43898      +46     
  Branches       6402     6386      -16     
============================================
+ Hits          26444    26499      +55     
+ Misses        14454    14422      -32     
- Partials       2954     2977      +23     
Impacted Files Coverage Δ
...bo/metadata/definition/model/MethodDefinition.java 69.69% <ø> (ø)
...o/metadata/definition/model/ServiceDefinition.java 58.82% <ø> (ø)
.../metadata/definition/ServiceDefinitionBuilder.java 83.72% <50.00%> (-2.77%) ⬇️
...ookeeper/ZookeeperDynamicConfigurationFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...pport/zookeeper/ZookeeperDynamicConfiguration.java 0.00% <0.00%> (-82.86%) ⬇️
.../configcenter/support/zookeeper/CacheListener.java 0.00% <0.00%> (-71.43%) ⬇️
...fig/configcenter/TreePathDynamicConfiguration.java 25.71% <0.00%> (-62.86%) ⬇️
...org/apache/dubbo/remoting/zookeeper/EventType.java 0.00% <0.00%> (-61.91%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-27.59%) ⬇️
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 76.92% <0.00%> (-15.39%) ⬇️
... and 129 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f26ba91...ea475ce. Read the comment docs.

@jingxiang
Copy link
Contributor Author

@jingxiang jingxiang commented Jun 22, 2021

Please fix ut

its ok

@jingxiang
Copy link
Contributor Author

@jingxiang jingxiang commented Jun 23, 2021

@AlbumenJ AlbumenJ merged commit 99ccb57 into apache:master Jun 24, 2021
10 checks passed
@zhangyz-hd
Copy link
Contributor

@zhangyz-hd zhangyz-hd commented Jun 25, 2021

Please in keeping with project Import-Layout.
See this file: /dubbo/codestyle/dubbo_codestyle_for_idea.xml

@jingxiang
Copy link
Contributor Author

@jingxiang jingxiang commented Jun 28, 2021

@zhangyz-hd act i use eclipse always.....

@jingxiang jingxiang deleted the bugfix_#7907 branch Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants