Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support <dubbo:annotation> element tag in xml when using legacy names… #7995

Merged
merged 1 commit into from Jun 9, 2021

Conversation

@xiaoduanayu
Copy link

@xiaoduanayu xiaoduanayu commented Jun 6, 2021

What is the purpose of the change

support dubbo:annotation element tag in xml when using legacy namespace.

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jun 7, 2021

Codecov Report

Merging #7995 (8fec07f) into master (744d302) will increase coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7995      +/-   ##
============================================
+ Coverage     60.03%   60.39%   +0.36%     
+ Complexity      489      456      -33     
============================================
  Files          1089     1089              
  Lines         43876    43876              
  Branches       6413     6395      -18     
============================================
+ Hits          26340    26501     +161     
+ Misses        14576    14413     -163     
- Partials       2960     2962       +2     
Impacted Files Coverage Δ
...e/dubbo/registry/consul/ConsulRegistryFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...g/apache/dubbo/registry/consul/ConsulRegistry.java 0.00% <0.00%> (-60.00%) ⬇️
...ntext/event/AwaitingNonWebApplicationListener.java 46.96% <0.00%> (-25.76%) ⬇️
...g/apache/dubbo/remoting/p2p/support/FileGroup.java 41.50% <0.00%> (-22.65%) ⬇️
...nfig/configcenter/nop/NopDynamicConfiguration.java 62.50% <0.00%> (-12.50%) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 35.52% <0.00%> (-10.53%) ⬇️
...o/remoting/transport/ChannelHandlerDispatcher.java 60.00% <0.00%> (-10.00%) ⬇️
.../threadpool/manager/DefaultExecutorRepository.java 80.95% <0.00%> (-4.77%) ⬇️
...mmon/serialize/kryo/utils/AbstractKryoFactory.java 75.43% <0.00%> (-3.51%) ⬇️
.../org/apache/dubbo/qos/legacy/LogTelnetHandler.java 30.30% <0.00%> (-3.04%) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 744d302...8fec07f. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 149d1f6 into apache:master Jun 9, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants