Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize URL#addParameters method to reuse existing methods #8005

Merged
merged 2 commits into from Jun 8, 2021

Conversation

@BurningCN
Copy link
Contributor

@BurningCN BurningCN commented Jun 8, 2021

What is the purpose of the change

Optimize URL#addParameters method to reuse existing methods

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jun 8, 2021

Codecov Report

Merging #8005 (36bdfc5) into master (9f6b536) will increase coverage by 0.07%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8005      +/-   ##
============================================
+ Coverage     60.85%   60.92%   +0.07%     
  Complexity      491      491              
============================================
  Files          1089     1090       +1     
  Lines         43876    43946      +70     
  Branches       6413     6421       +8     
============================================
+ Hits          26699    26774      +75     
+ Misses        14208    14195      -13     
- Partials       2969     2977       +8     
Impacted Files Coverage Δ
...mon/src/main/java/org/apache/dubbo/common/URL.java 50.10% <50.00%> (-0.11%) ⬇️
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) ⬇️
...n/java/org/apache/dubbo/common/utils/LFUCache.java 80.86% <0.00%> (-5.42%) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0.00%> (-1.91%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 77.40% <0.00%> (-1.49%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 69.54% <0.00%> (-1.15%) ⬇️
...etadata/report/support/AbstractMetadataReport.java 59.70% <0.00%> (-0.98%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 81.02% <0.00%> (-0.26%) ⬇️
...n/java/org/apache/dubbo/config/ConsumerConfig.java 92.85% <0.00%> (ø)
...apache/dubbo/rpc/cluster/support/ClusterUtils.java 60.00% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f6b536...36bdfc5. Read the comment docs.

Copy link
Contributor

@chickenlj chickenlj left a comment

LGTM.

@chickenlj chickenlj merged commit ed88f43 into apache:master Jun 8, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants