Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix urls may be null, and NullPointerException will be thrown in ConfigValidationUtils (#8020) #8021

Merged
merged 2 commits into from Jun 10, 2021

Conversation

@skyguard1
Copy link
Contributor

@skyguard1 skyguard1 commented Jun 9, 2021

What is the purpose of the change

Fix urls may be null, and NullPointerException will be thrown in ConfigValidationUtils
In this issue(#8020 ), this pr is to fix this issue, to avoid throwing NullPointerException in ConfigValidationUtils, thanks

Fixes #8020

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.
…igValidationUtils (apache#8020)

Signed-off-by: xingrufei <xingrufei@sogou-inc.com>
Copy link
Contributor

@xiaoheng1 xiaoheng1 left a comment

In my opinion, this place address should not be empty, if it is empty, an exception should be thrown

Signed-off-by: xingrufei <xingrufei@sogou-inc.com>
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jun 10, 2021

Codecov Report

Merging #8021 (21e2f08) into master (584ab28) will increase coverage by 0.04%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8021      +/-   ##
============================================
+ Coverage     61.02%   61.07%   +0.04%     
- Complexity      489      490       +1     
============================================
  Files          1090     1090              
  Lines         43951    43953       +2     
  Branches       6423     6424       +1     
============================================
+ Hits          26822    26843      +21     
+ Misses        14151    14124      -27     
- Partials       2978     2986       +8     
Impacted Files Coverage Δ
...ache/dubbo/config/utils/ConfigValidationUtils.java 73.33% <0.00%> (-0.50%) ⬇️
...port/identifier/BaseServiceMetadataIdentifier.java 57.14% <0.00%> (-3.58%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 80.81% <0.00%> (-0.43%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 70.68% <0.00%> (+1.14%) ⬆️
.../src/main/java/org/apache/dubbo/rpc/RpcStatus.java 73.80% <0.00%> (+1.19%) ⬆️
...e/dubbo/remoting/transport/netty4/NettyClient.java 71.01% <0.00%> (+1.44%) ⬆️
.../dubbo/remoting/transport/netty4/NettyChannel.java 64.35% <0.00%> (+1.98%) ⬆️
...etadata/report/support/AbstractMetadataReport.java 59.70% <0.00%> (+2.42%) ⬆️
...o/remoting/transport/ChannelHandlerDispatcher.java 70.00% <0.00%> (+10.00%) ⬆️
...che/dubbo/remoting/transport/mina/MinaChannel.java 46.05% <0.00%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 584ab28...21e2f08. Read the comment docs.

@chickenlj chickenlj merged commit e6f39cd into apache:master Jun 10, 2021
10 checks passed
@chickenlj chickenlj added this to the 2.7.13 milestone Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants