Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize StatusTelnetHandler code and extract constants #8041

Merged
merged 1 commit into from Jun 15, 2021

Conversation

@xiaoheng1
Copy link
Contributor

@xiaoheng1 xiaoheng1 commented Jun 13, 2021

What is the purpose of the change

Optimize StatusTelnetHandler code and extract constants

see more detail from #8040

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jun 13, 2021

Codecov Report

Merging #8041 (e61abbf) into master (50d88d7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8041      +/-   ##
============================================
+ Coverage     61.12%   61.14%   +0.01%     
- Complexity      490      491       +1     
============================================
  Files          1090     1090              
  Lines         43967    43967              
  Branches       6428     6428              
============================================
+ Hits          26877    26882       +5     
+ Misses        14104    14103       -1     
+ Partials       2986     2982       -4     
Impacted Files Coverage Δ
...ng/telnet/support/command/StatusTelnetHandler.java 84.09% <100.00%> (ø)
...g/apache/dubbo/remoting/p2p/support/FileGroup.java 50.94% <0.00%> (-13.21%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 81.23% <0.00%> (+0.21%) ⬆️
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.58% <0.00%> (+0.58%) ⬆️
...he/dubbo/registry/multicast/MulticastRegistry.java 70.23% <0.00%> (+0.93%) ⬆️
...pache/dubbo/registry/support/AbstractRegistry.java 78.88% <0.00%> (+1.48%) ⬆️
...he/dubbo/remoting/transport/netty/NettyServer.java 73.68% <0.00%> (+3.50%) ⬆️
...ng/transport/dispatcher/all/AllChannelHandler.java 96.55% <0.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50d88d7...e61abbf. Read the comment docs.

Copy link
Contributor

@BurningCN BurningCN left a comment

LGTM

@AlbumenJ AlbumenJ merged commit 8892a36 into apache:master Jun 15, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants