Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize generic filter #8067

Merged
merged 1 commit into from Jun 18, 2021
Merged

Conversation

@goodjava
Copy link
Contributor

@goodjava goodjava commented Jun 16, 2021

optimize generic filter

@goodjava goodjava force-pushed the optimize_gson_genericfilter branch from 3a797e5 to e115c22 Jun 16, 2021
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jun 16, 2021

Codecov Report

Merging #8067 (e115c22) into master (8892a36) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8067      +/-   ##
============================================
- Coverage     61.16%   61.15%   -0.01%     
+ Complexity      491      490       -1     
============================================
  Files          1091     1091              
  Lines         43953    43955       +2     
  Branches       6417     6417              
============================================
- Hits          26882    26880       -2     
- Misses        14088    14090       +2     
- Partials       2983     2985       +2     
Impacted Files Coverage Δ
...ava/org/apache/dubbo/rpc/filter/GenericFilter.java 37.90% <33.33%> (+0.19%) ⬆️
...che/dubbo/remoting/transport/mina/MinaChannel.java 35.52% <0.00%> (-10.53%) ⬇️
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 62.06% <0.00%> (-10.35%) ⬇️
...ting/exchange/support/header/HeartbeatHandler.java 83.72% <0.00%> (-9.31%) ⬇️
.../remoting/transport/netty4/NettyClientHandler.java 83.05% <0.00%> (-3.39%) ⬇️
...e/dubbo/remoting/exchange/codec/ExchangeCodec.java 77.73% <0.00%> (-2.43%) ⬇️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 86.66% <0.00%> (-1.91%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 89.65% <0.00%> (ø)
...apache/dubbo/common/extension/ExtensionLoader.java 81.02% <0.00%> (+0.21%) ⬆️
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.58% <0.00%> (+0.58%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8892a36...e115c22. Read the comment docs.

Copy link
Contributor

@xiaoheng1 xiaoheng1 left a comment

LGTM

@AlbumenJ AlbumenJ merged commit b16a404 into apache:master Jun 18, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants