Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay export service should print stack trace if there are exception o… #8125

Merged
merged 1 commit into from Jun 28, 2021

Conversation

@AvengerEug
Copy link

@AvengerEug AvengerEug commented Jun 23, 2021

What is the purpose of the change

Optimize delay export service logic.

Pre condition:
If module A and B dependency the same dubbo-config core, and it define netty server port is 20880, config delay export service time is 1000 and protocol is dubbo.

Usage scenarios:
When I run module B after successfully started module A at the same compute, module B can successfully started, but module B not export any service, because module A occupied 21880 port.

Conclusion:
So, I think delay export service should print stack trace if there are exception occur so that programmer can see errors in console.

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.
@AvengerEug AvengerEug changed the title Delay export server should print stack trace if there are exception o… Delay export service should print stack trace if there are exception o… Jun 24, 2021
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jun 28, 2021

Codecov Report

Merging #8125 (0f9d62a) into master (b194bb0) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8125      +/-   ##
============================================
+ Coverage     61.14%   61.16%   +0.02%     
  Complexity      490      490              
============================================
  Files          1090     1090              
  Lines         43937    43942       +5     
  Branches       6418     6418              
============================================
+ Hits          26867    26879      +12     
+ Misses        14091    14080      -11     
- Partials       2979     2983       +4     
Impacted Files Coverage Δ
...in/java/org/apache/dubbo/config/ServiceConfig.java 66.66% <100.00%> (+0.48%) ⬆️
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.38% <0.00%> (-2.98%) ⬇️
...pache/dubbo/remoting/transport/AbstractServer.java 61.42% <0.00%> (-1.43%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 69.54% <0.00%> (-1.15%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 81.23% <0.00%> (+0.21%) ⬆️
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.58% <0.00%> (+0.58%) ⬆️
...a/org/apache/dubbo/monitor/dubbo/DubboMonitor.java 88.57% <0.00%> (+1.90%) ⬆️
.../apache/dubbo/rpc/protocol/AsyncToSyncInvoker.java 72.41% <0.00%> (+10.34%) ⬆️
...che/dubbo/remoting/transport/mina/MinaChannel.java 46.05% <0.00%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b194bb0...0f9d62a. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 11b9936 into apache:master Jun 28, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants