Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use service name mapping key to avoid logic conflict. #8184

Merged
merged 1 commit into from Jul 2, 2021

Conversation

@horizonzy
Copy link
Member

@horizonzy horizonzy commented Jun 30, 2021

What is the purpose of the change

Now use REGISTRY_TYPE_KEY to judge is publish service name mapping or not, but this key is meaningful for RegistryProtol, maybe it will influence the origin logic.

So add a particular key to judge is publish service name mapping info or not.

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jun 30, 2021

Codecov Report

Merging #8184 (2677643) into master (149d1f6) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8184      +/-   ##
============================================
+ Coverage     60.99%   61.21%   +0.21%     
  Complexity      490      490              
============================================
  Files          1090     1090              
  Lines         43951    43950       -1     
  Branches       6423     6418       -5     
============================================
+ Hits          26810    26905      +95     
+ Misses        14156    14065      -91     
+ Partials       2985     2980       -5     
Impacted Files Coverage Δ
...apache/dubbo/common/constants/CommonConstants.java 100.00% <ø> (ø)
...in/java/org/apache/dubbo/config/ServiceConfig.java 66.57% <100.00%> (+4.03%) ⬆️
...g/apache/dubbo/remoting/p2p/support/FileGroup.java 41.50% <0.00%> (-22.65%) ⬇️
...mmon/serialize/kryo/utils/AbstractKryoFactory.java 75.43% <0.00%> (-3.51%) ⬇️
.../metadata/definition/ServiceDefinitionBuilder.java 83.72% <0.00%> (-2.77%) ⬇️
...bo/registry/client/FileSystemServiceDiscovery.java 67.44% <0.00%> (-2.33%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 77.40% <0.00%> (-1.49%) ⬇️
...figcenter/file/FileSystemDynamicConfiguration.java 31.42% <0.00%> (-0.96%) ⬇️
.../org/apache/dubbo/monitor/dubbo/MetricsFilter.java 66.98% <0.00%> (-0.95%) ⬇️
...gistry/client/EventPublishingServiceDiscovery.java 72.83% <0.00%> (-0.92%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 149d1f6...2677643. Read the comment docs.

Copy link
Contributor

@xiaoheng1 xiaoheng1 left a comment

LGTM

@AlbumenJ AlbumenJ merged commit c5a4597 into apache:master Jul 2, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants