Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For compatible nacos server lower version, we should check the response from nacos server is null. #8229

Merged
merged 1 commit into from Jul 11, 2021

Conversation

@horizonzy
Copy link
Member

@horizonzy horizonzy commented Jul 5, 2021

What is the purpose of the change

Fix #8181

At provider, it won't register service name mapping info.
At consumer, we will use application_first, it will use service discovery logic to find service name mapping info,
in NacosDynamicConfiguration, use httpAgent to get service name mapping info, but at nacos server lower version, if the config is not found, will return null response.

So we should do compatible work for lower nacos server version.

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jul 5, 2021

Codecov Report

Merging #8229 (20b7edb) into master (149d1f6) will decrease coverage by 0.19%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8229      +/-   ##
============================================
- Coverage     60.99%   60.80%   -0.20%     
+ Complexity      490      456      -34     
============================================
  Files          1090     1090              
  Lines         43951    43955       +4     
  Branches       6423     6421       -2     
============================================
- Hits          26810    26726      -84     
- Misses        14156    14250      +94     
+ Partials       2985     2979       -6     
Impacted Files Coverage Δ
...enter/support/nacos/NacosDynamicConfiguration.java 0.00% <0.00%> (ø)
...e/dubbo/registry/consul/ConsulRegistryFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...g/apache/dubbo/registry/consul/ConsulRegistry.java 0.00% <0.00%> (-60.00%) ⬇️
...g/apache/dubbo/remoting/p2p/support/FileGroup.java 41.50% <0.00%> (-22.65%) ⬇️
...nfig/configcenter/nop/NopDynamicConfiguration.java 62.50% <0.00%> (-12.50%) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 35.52% <0.00%> (-10.53%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-6.90%) ⬇️
.../threadpool/manager/DefaultExecutorRepository.java 80.95% <0.00%> (-4.77%) ⬇️
...ng/transport/dispatcher/WrappedChannelHandler.java 58.69% <0.00%> (-4.35%) ⬇️
...o/rpc/cluster/support/migration/MigrationRule.java 50.00% <0.00%> (-3.58%) ⬇️
... and 44 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 149d1f6...20b7edb. Read the comment docs.

Copy link
Contributor

@xiaoheng1 xiaoheng1 left a comment

LGTM

@AlbumenJ AlbumenJ merged commit 34a4922 into apache:master Jul 11, 2021
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants