Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable telnet by default #8239

Merged
merged 4 commits into from Jul 9, 2021
Merged

Conversation

@chickenlj
Copy link
Contributor

@chickenlj chickenlj commented Jul 7, 2021

No description provided.

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jul 7, 2021

Codecov Report

Merging #8239 (cd5a5da) into master (c5a4597) will increase coverage by 0.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8239      +/-   ##
============================================
+ Coverage     60.82%   61.26%   +0.44%     
- Complexity      456      489      +33     
============================================
  Files          1090     1090              
  Lines         43950    43963      +13     
  Branches       6418     6420       +2     
============================================
+ Hits          26732    26934     +202     
+ Misses        14243    14053     -190     
- Partials       2975     2976       +1     
Impacted Files Coverage Δ
...va/org/apache/dubbo/common/config/Environment.java 83.33% <100.00%> (+0.57%) ⬆️
...apache/dubbo/common/extension/ExtensionLoader.java 81.31% <100.00%> (+0.50%) ⬆️
...ava/org/apache/dubbo/config/DubboShutdownHook.java 88.46% <100.00%> (-0.91%) ⬇️
.../apache/dubbo/config/bootstrap/DubboBootstrap.java 54.74% <100.00%> (+0.05%) ⬆️
.../remoting/telnet/support/TelnetHandlerAdapter.java 52.27% <100.00%> (ø)
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
...tadata/DynamicConfigurationServiceNameMapping.java 45.45% <0.00%> (-6.07%) ⬇️
...he/dubbo/registry/multicast/MulticastRegistry.java 67.44% <0.00%> (-2.33%) ⬇️
...he/dubbo/registry/zookeeper/ZookeeperRegistry.java 60.24% <0.00%> (-1.21%) ⬇️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5a4597...cd5a5da. Read the comment docs.

@chickenlj chickenlj requested a review from kylixs Jul 9, 2021
kylixs
kylixs approved these changes Jul 9, 2021
@kylixs kylixs merged commit 11e15f2 into apache:master Jul 9, 2021
10 checks passed
@chickenlj chickenlj deleted the disable-telnet-by-default branch Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants