Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance metadata report config. #8268

Merged
merged 2 commits into from Jul 12, 2021

Conversation

@horizonzy
Copy link
Member

@horizonzy horizonzy commented Jul 11, 2021

1.metadata-report-config support protocol and port.
2.make ConfigCenterConfig setAddress be same with RegistryConfig.

horizonzy added 2 commits Jul 11, 2021
2.make ConfigCenterConfig setAddress be same with RegistryConfig.
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jul 11, 2021

Codecov Report

Merging #8268 (a32e71c) into master (11e15f2) will increase coverage by 0.00%.
The diff coverage is 68.75%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8268   +/-   ##
=========================================
  Coverage     61.24%   61.25%           
- Complexity      489      490    +1     
=========================================
  Files          1090     1090           
  Lines         43963    43994   +31     
  Branches       6420     6427    +7     
=========================================
+ Hits          26924    26947   +23     
- Misses        14063    14077   +14     
+ Partials       2976     2970    -6     
Impacted Files Coverage Δ
...n/java/org/apache/dubbo/config/RegistryConfig.java 86.17% <ø> (ø)
.../org/apache/dubbo/config/MetadataReportConfig.java 79.51% <66.66%> (-5.23%) ⬇️
...va/org/apache/dubbo/config/ConfigCenterConfig.java 72.91% <75.00%> (-6.88%) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
...e/dubbo/remoting/transport/netty4/NettyClient.java 69.56% <0.00%> (-1.45%) ⬇️
...ting/zookeeper/curator/CuratorZookeeperClient.java 68.96% <0.00%> (-1.15%) ⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 79.72% <0.00%> (-0.35%) ⬇️
...enter/support/nacos/NacosDynamicConfiguration.java 0.00% <0.00%> (ø)
...pache/dubbo/registry/support/AbstractRegistry.java 78.88% <0.00%> (+0.37%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11e15f2...a32e71c. Read the comment docs.

@AlbumenJ AlbumenJ merged commit 3548eab into apache:master Jul 12, 2021
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants