Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ShortestResponseLoadBalance active param #8318

Merged
merged 1 commit into from Jul 23, 2021
Merged

Conversation

@24kpure
Copy link
Contributor

@24kpure 24kpure commented Jul 19, 2021

What is the purpose of the change

ShortestResponseLoadBalance works as a RandomLoadBalance when the active value is zero ,but succeededAverageElapsed isn't zero.In my opinion, once succeededAverageElapsed is bigger than zero,ShortestResponseLoadBalance will chose the shortest invoker.

Brief changelog

Active value should be bigger than zero so that succeededAverageElapsed can play a vital role in this case.

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jul 19, 2021

Codecov Report

Merging #8318 (8bb51de) into master (352a0df) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8318      +/-   ##
============================================
- Coverage     61.29%   61.26%   -0.03%     
- Complexity      446      447       +1     
============================================
  Files          1096     1096              
  Lines         44212    44212              
  Branches       6445     6445              
============================================
- Hits          27099    27088      -11     
- Misses        14136    14144       +8     
- Partials       2977     2980       +3     
Impacted Files Coverage Δ
...uster/loadbalance/ShortestResponseLoadBalance.java 84.61% <100.00%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 82.75% <0.00%> (-13.80%) ⬇️
...o/remoting/transport/ChannelHandlerDispatcher.java 60.00% <0.00%> (-10.00%) ⬇️
...he/dubbo/remoting/transport/netty/NettyHelper.java 35.48% <0.00%> (-6.46%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 82.05% <0.00%> (-5.13%) ⬇️
.../apache/dubbo/remoting/transport/AbstractPeer.java 58.69% <0.00%> (-4.35%) ⬇️
...ting/exchange/support/header/HeartbeatHandler.java 90.69% <0.00%> (-2.33%) ⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 79.72% <0.00%> (-0.35%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 79.62% <0.00%> (+0.74%) ⬆️
...che/dubbo/remoting/transport/mina/MinaChannel.java 46.05% <0.00%> (+10.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 352a0df...8bb51de. Read the comment docs.

@AlbumenJ AlbumenJ changed the base branch from master to 3.0 Jul 23, 2021
@AlbumenJ AlbumenJ changed the base branch from 3.0 to master Jul 23, 2021
@AlbumenJ AlbumenJ merged commit 41e989b into apache:master Jul 23, 2021
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants