Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instance change event name format problem. #8346

Merged

Conversation

@horizonzy
Copy link
Member

@horizonzy horizonzy commented Jul 24, 2021

What is the purpose of the change

Nacos NamingEvent's name is group@@servicename.

It can't be pass by predicateEventListener.accept(event), the predicateEventListener's hold serviceNames format is serviceName, which is not formatted as group@@servicename.

if (!predicateEventListener.accept(event)) { // No accept

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jul 24, 2021

Codecov Report

Merging #8346 (fcd33b6) into master (11e15f2) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8346      +/-   ##
============================================
+ Coverage     61.24%   61.25%   +0.01%     
+ Complexity      489      445      -44     
============================================
  Files          1090     1096       +6     
  Lines         43963    44212     +249     
  Branches       6420     6445      +25     
============================================
+ Hits          26924    27084     +160     
- Misses        14063    14143      +80     
- Partials       2976     2985       +9     
Impacted Files Coverage Δ
...he/dubbo/registry/nacos/NacosServiceDiscovery.java 0.00% <0.00%> (ø)
...ookeeper/ZookeeperDynamicConfigurationFactory.java 66.66% <0.00%> (-33.34%) ⬇️
...in/java/org/apache/dubbo/common/utils/JVMUtil.java 81.13% <0.00%> (-11.33%) ⬇️
...va/org/apache/dubbo/config/ConfigCenterConfig.java 72.91% <0.00%> (-6.88%) ⬇️
.../org/apache/dubbo/config/MetadataReportConfig.java 79.51% <0.00%> (-5.23%) ⬇️
...o/serialize/hessian/Hessian2SerializerFactory.java 77.14% <0.00%> (-2.86%) ⬇️
...rg/apache/dubbo/common/timer/HashedWheelTimer.java 79.72% <0.00%> (-0.35%) ⬇️
...n/java/org/apache/dubbo/config/RegistryConfig.java 86.17% <0.00%> (ø)
...o/registry/zookeeper/ZookeeperRegistryFactory.java 100.00% <0.00%> (ø)
...e/dubbo/serialize/hessian/Hessian2ObjectInput.java 0.00% <0.00%> (ø)
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11e15f2...fcd33b6. Read the comment docs.

@horizonzy horizonzy merged commit d82ce47 into apache:master Jul 27, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants