Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix String.format lack of arg which is from BroadcastClusterInvoker #8348

Merged
merged 1 commit into from Jul 27, 2021

Conversation

@xiaoheng1
Copy link
Contributor

@xiaoheng1 xiaoheng1 commented Jul 25, 2021

What is the purpose of the change

String.format lack of arg which is from BroadcastClusterInvoker

see #8341

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jul 25, 2021

Codecov Report

Merging #8348 (8b5923e) into master (41e989b) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8348   +/-   ##
=========================================
  Coverage     61.26%   61.26%           
  Complexity      447      447           
=========================================
  Files          1096     1096           
  Lines         44212    44212           
  Branches       6445     6445           
=========================================
+ Hits          27085    27087    +2     
+ Misses        14146    14141    -5     
- Partials       2981     2984    +3     
Impacted Files Coverage Δ
...o/rpc/cluster/support/BroadcastClusterInvoker.java 0.00% <0.00%> (ø)
.../dubbo/remoting/transport/netty4/NettyChannel.java 61.38% <0.00%> (-2.98%) ⬇️
...pache/dubbo/registry/support/AbstractRegistry.java 78.14% <0.00%> (-1.49%) ⬇️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 52.87% <0.00%> (-1.15%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 81.10% <0.00%> (ø)
...ng/transport/dispatcher/all/AllChannelHandler.java 89.65% <0.00%> (ø)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 60.58% <0.00%> (+0.58%) ⬆️
...ting/zookeeper/curator/CuratorZookeeperClient.java 70.11% <0.00%> (+1.14%) ⬆️
...ting/exchange/support/header/HeartbeatHandler.java 93.02% <0.00%> (+2.32%) ⬆️
...etadata/report/support/AbstractMetadataReport.java 59.70% <0.00%> (+3.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41e989b...8b5923e. Read the comment docs.

@pinxiong
Copy link
Member

@pinxiong pinxiong commented Jul 25, 2021

LGTM

Copy link
Contributor

@BurningCN BurningCN left a comment

LGTM

@horizonzy horizonzy merged commit b142cdb into apache:master Jul 27, 2021
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants