Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix migrationRule bug #8358

Merged
merged 2 commits into from Jul 27, 2021
Merged

fix migrationRule bug #8358

merged 2 commits into from Jul 27, 2021

Conversation

@xiaoheng1
Copy link
Contributor

@xiaoheng1 xiaoheng1 commented Jul 27, 2021

What is the purpose of the change

fix migrationRule bug

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Jul 27, 2021

Codecov Report

Merging #8358 (d27593a) into master (d82ce47) will decrease coverage by 0.26%.
The diff coverage is 7.69%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #8358      +/-   ##
============================================
- Coverage     61.28%   61.01%   -0.27%     
+ Complexity      447      445       -2     
============================================
  Files          1096     1096              
  Lines         44212    44177      -35     
  Branches       6445     6414      -31     
============================================
- Hits          27094    26955     -139     
- Misses        14135    14237     +102     
- Partials       2983     2985       +2     
Impacted Files Coverage Δ
...o/rpc/cluster/support/migration/MigrationRule.java 44.73% <7.69%> (-12.41%) ⬇️
...ng/transport/dispatcher/all/AllChannelHandler.java 62.06% <0.00%> (-34.49%) ⬇️
...rg/apache/dubbo/remoting/utils/PayloadDropper.java 76.92% <0.00%> (-15.39%) ⬇️
...ng/transport/dispatcher/WrappedChannelHandler.java 47.82% <0.00%> (-15.22%) ⬇️
...dubbo/common/status/support/LoadStatusChecker.java 50.00% <0.00%> (-11.54%) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 35.52% <0.00%> (-10.53%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 76.99% <0.00%> (-10.19%) ⬇️
.../remoting/transport/netty4/NettyClientHandler.java 76.27% <0.00%> (-10.17%) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 54.45% <0.00%> (-9.91%) ⬇️
...mmon/threadpool/support/fixed/FixedThreadPool.java 80.00% <0.00%> (-7.50%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d82ce47...d27593a. Read the comment docs.

Copy link
Contributor

@chickenlj chickenlj left a comment

LGTM

@chickenlj chickenlj merged commit bfa4b3b into apache:master Jul 27, 2021
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants